nikic wrote:
Using the term for MIR is okay, because it does not have a pre-existing notion
of canonical form. Doing the same for IR is not okay, because it already has a
canonical form and this pass does not produce it. Calling this `ir-normalizer`
instead of `ir-canonicalizer` should convey
michalpaszkowski wrote:
> Please don't use the term canon/canonicalize for this pass or tool. LLVM has
> an existing notion of "canonicalization" which does not coincide with what is
> being done here.
@nikic I don't think the name "canon" or "canonicalizer" will lead to any
confusion here.
plotfi wrote:
> Please don't use the term canon/canonicalize for this pass or tool. LLVM has
> an existing notion of "canonicalization" which does not coincide with what is
> being done here.
The term comes from an older pass that did similar algorithms on MIR. They are
only borrowing the
nikic wrote:
Please don't use the term canon/canonicalize for this pass or tool. LLVM has an
existing notion of "canonicalization" which does coincide with what is being
done here.
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits
plotfi wrote:
I recall approving the original PR on phab. I can re-review if needed. This
work was approved to land before, so personally I think it might be overkill to
RFC it on discourse again but I am not certain of the right process to take.
> Added @plotfi as a reviewer; one drive-by
@@ -0,0 +1,638 @@
+//===--- IRCanonicalizer.cpp - IR Canonicalizer
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/16] Add IRCanonicalizer.cpp
---
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/15] Add IRCanonicalizer.cpp
---
@@ -0,0 +1,638 @@
+//===--- IRCanonicalizer.cpp - IR Canonicalizer
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
michalpaszkowski wrote:
Thank you @justinfargnoli and @AidanGoldfarb for taking over this work and
reaching out! I will review your changes in the coming week.
CC @ChrisCummins FYI
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 8641cdf397d86f33ac45e4c691ca4f843c359370
90912d2b40121936c239f9275bebd52db5d3a116 --
https://github.com/justinfargnoli created
https://github.com/llvm/llvm-project/pull/68176
Add the llvm-canon tool. Description from the [original
PR](https://reviews.llvm.org/D66029#change-wZv3yOpDdxIu):
> Added a new llvm-canon tool which aims to transform LLVM Modules into a
> canonical
12 matches
Mail list logo
