https://github.com/dtcxzyw closed
https://github.com/llvm/llvm-project/pull/67915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/67915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/67915
>From c4ce28c942c172e5646b5922f0b02b4169197840 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Sun, 1 Oct 2023 21:52:47 +0800
Subject: [PATCH 1/2] [InstCombine] Canonicalize `(X +/- Y) & Y` into `~X & Y`
nikic wrote:
Can you please pre-commit the new tests as well (and double-check that there is
no unexpected operand order canonicalization while doing that)?
https://github.com/llvm/llvm-project/pull/67915
___
cfe-commits mailing list
https://github.com/nikic commented:
Seems like some test coverage is missing here?
* Commuted add
* Commuted sub (negative test)
* Commuted and
* Multi-use add (negative test)
https://github.com/llvm/llvm-project/pull/67915
___
cfe-commits mailing