https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/78463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> I might suggest `isPureVirtual` as it better reflects the 'term of art'
> (https://en.cppreference.com/w/cpp/language/abstract_class see 'A pure
> virtual function is a).
>
> Else LG and SG TM.
I have the same preference for `isPureVirtual` but otherwise LGTM.
https://github.com/erichkeane approved this pull request.
I might suggest `isPureVirtual` as it better reflects the 'term of art'
(https://en.cppreference.com/w/cpp/language/abstract_class see 'A pure virtual
function is a).
Else LG and SG TM.
pogo59 wrote:
I think "pure virtual" is a more common phrasing than "virtual pure" so maybe
`isPureVirtual` instead? Up to Aaron, though.
https://github.com/llvm/llvm-project/pull/78463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
@llvm/pr-subscribers-clang-tidy
Author: cor3ntin (cor3ntin)
Changes
To avoid any possible confusion with the notion of pure function and the
gnu::pure attribute.
---
Patch is 27.47 KiB, truncated to 20.00 KiB below, full version:
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/78463
To avoid any possible confusion with the notion of pure function and the
gnu::pure attribute.
>From dccf65bc3771b1885c70e47e7d786c662c7f4fd3 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Wed, 17 Jan
