https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/75061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/75061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/75061
>From c3938da3a94ed9a9cc86d006d4b39dc5b73e7114 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 11 Dec 2023 23:32:32 +0800
Subject: [PATCH] [clang-tidy][misleading-indentation]ignore false-positives
https://github.com/PiotrZSL requested changes to this pull request.
+- fine, fix pointed out nits and could land
https://github.com/llvm/llvm-project/pull/75061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -51,8 +52,22 @@ void MisleadingIndentationCheck::danglingElseCheck(const
SourceManager ,
diag(ElseLoc, "different indentation for 'if' and corresponding 'else'");
}
-void MisleadingIndentationCheck::missingBracesCheck(const SourceManager ,
-
@@ -51,8 +52,22 @@ void MisleadingIndentationCheck::danglingElseCheck(const
SourceManager ,
diag(ElseLoc, "different indentation for 'if' and corresponding 'else'");
}
-void MisleadingIndentationCheck::missingBracesCheck(const SourceManager ,
-
@@ -51,8 +52,22 @@ void MisleadingIndentationCheck::danglingElseCheck(const
SourceManager ,
diag(ElseLoc, "different indentation for 'if' and corresponding 'else'");
}
-void MisleadingIndentationCheck::missingBracesCheck(const SourceManager ,
-
@@ -453,6 +453,10 @@ Changes in existing checks
` check to ignore
false-positives in initializer list of record.
+- Improved :doc:`readability-misleading-indentation
EugeneZelenko wrote:
Please keep alphabetical order (by check name).
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Congcong Cai (HerrCai0907)
Changes
Fixes: #71767
---
Full diff: https://github.com/llvm/llvm-project/pull/75061.diff
4 Files Affected:
- (modified)
clang-tools-extra/clang-tidy/readability/MisleadingIndentationCheck.cpp (+21-3)
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/75061
Fixes: #71767
>From e710a0568c73e87296b4df03ac6746766bd87c3a Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 11 Dec 2023 23:32:32 +0800
Subject: [PATCH] [clang-tidy][misleading-indentation]ignore
10 matches
Mail list logo