https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/65558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/65558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 resolved
https://github.com/llvm/llvm-project/pull/65558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/65558:
>From f25a855ac2d3ec4b89f55a08e415596b3b65f142 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 7 Sep 2023 10:14:28 +0800
Subject: [PATCH 1/3] [clang-tidy][modernize-use-using]fix function pointer
HerrCai0907 wrote:
> This is weird issues because it always happen when two typedefs are one after
> other.
```c++
typedef void (*ISSUE_65055_1)(int);
typedef bool (*ISSUE_65055_2)(int);
typedef void VOID;
```
The typedef matcher will match following position:
```
TypedefDecl 0x1610ba960
https://github.com/PiotrZSL approved this pull request.
LGTM,
This is weird issues because it always happen when two typedefs are one after
other.
I would personally thing more that LastReplacementEnd is to big, not too small.
But if tests check this properly, then I'm fine with it.
@@ -314,3 +314,10 @@ typedef struct { struct { int a; struct { struct { int b;
} c; int d; } e; } f;
typedef struct { struct { int a; } b; union { int c; float d; struct { int e;
}; }; struct { double f; } g; } PR50990_siblings;
// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: use
https://github.com/PiotrZSL resolved
https://github.com/llvm/llvm-project/pull/65558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -314,3 +314,10 @@ typedef struct { struct { int a; struct { struct { int b;
} c; int d; } e; } f;
typedef struct { struct { int a; } b; union { int c; float d; struct { int e;
}; }; struct { double f; } g; } PR50990_siblings;
// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: use
https://github.com/HerrCai0907 review_requested
https://github.com/llvm/llvm-project/pull/65558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/65558:
>From f25a855ac2d3ec4b89f55a08e415596b3b65f142 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 7 Sep 2023 10:14:28 +0800
Subject: [PATCH 1/2] [clang-tidy][modernize-use-using]fix function pointer
https://github.com/HerrCai0907 resolved
https://github.com/llvm/llvm-project/pull/65558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 resolved
https://github.com/llvm/llvm-project/pull/65558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/65558:
>From f25a855ac2d3ec4b89f55a08e415596b3b65f142 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 7 Sep 2023 10:14:28 +0800
Subject: [PATCH 1/2] [clang-tidy][modernize-use-using]fix function pointer
@@ -314,3 +314,10 @@ typedef struct { struct { int a; struct { struct { int b;
} c; int d; } e; } f;
typedef struct { struct { int a; } b; union { int c; float d; struct { int e;
}; }; struct { double f; } g; } PR50990_siblings;
// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: use
@@ -246,6 +246,9 @@ Changes in existing checks
` check to accurately generate
fixes for reordering arguments.
+- Improved :doc:`modernize-use-using`
PiotrZSL wrote:
put space before <, juts for visibility.
@@ -314,3 +314,10 @@ typedef struct { struct { int a; struct { struct { int b;
} c; int d; } e; } f;
typedef struct { struct { int a; } b; union { int c; float d; struct { int e;
}; }; struct { double f; } g; } PR50990_siblings;
// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: use
@@ -314,3 +314,10 @@ typedef struct { struct { int a; struct { struct { int b;
} c; int d; } e; } f;
typedef struct { struct { int a; } b; union { int c; float d; struct { int e;
}; }; struct { double f; } g; } PR50990_siblings;
// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: use
https://github.com/github-actions[bot] labeled
https://github.com/llvm/llvm-project/pull/65558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 review_requested
https://github.com/llvm/llvm-project/pull/65558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 review_requested
https://github.com/llvm/llvm-project/pull/65558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 review_requested
https://github.com/llvm/llvm-project/pull/65558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 review_requested
https://github.com/llvm/llvm-project/pull/65558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/65558:
Fixed #65055
>From f25a855ac2d3ec4b89f55a08e415596b3b65f142 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 7 Sep 2023 10:14:28 +0800
Subject: [PATCH] [clang-tidy][modernize-use-using]fix function
24 matches
Mail list logo
