https://github.com/isuckatcs closed
https://github.com/llvm/llvm-project/pull/82403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,182 @@
+//===--- CrtpConstructorAccessibilityCheck.cpp - clang-tidy
+//-===//
PiotrZSL wrote:
renamer...
https://github.com/llvm/llvm-project/pull/82403
___
cfe-commits
@@ -0,0 +1,182 @@
+//===--- CrtpConstructorAccessibilityCheck.cpp - clang-tidy
+//-===//
isuckatcs wrote:
I guess either the checker creator script or the renamer doesn't look at the
character count. We could consider modifying
@@ -0,0 +1,182 @@
+//===--- CrtpConstructorAccessibilityCheck.cpp - clang-tidy
+//-===//
PiotrZSL wrote:
This should be in single line
https://github.com/llvm/llvm-project/pull/82403
https://github.com/PiotrZSL approved this pull request.
Overall looks fine, at least fine to be merged.
I will try to take a deeper look into particular cases, but even if some
changes could be needed, probably better would be to merge this, and push fixes
in separate PR.
So lest merge this,
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/82403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
isuckatcs wrote:
ping @PiotrZSL @whisperity
https://github.com/llvm/llvm-project/pull/82403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/isuckatcs edited
https://github.com/llvm/llvm-project/pull/82403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
