torshepherd wrote:
I'll close this patch and pursue the other things we discussed
https://github.com/llvm/llvm-project/pull/79448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/torshepherd closed
https://github.com/llvm/llvm-project/pull/79448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HighCommander4 wrote:
I read up on this a bit; https://github.com/Microsoft/vscode/issues/62110 seems
particularly relevant.
Based on [this
comment](https://github.com/Microsoft/vscode/issues/62110#issuecomment-456240329):
> [...] we have an `auto fix` action in the editor that fixes
HighCommander4 wrote:
> However, this doesn't seem to change the behavior in vscode:
I applied the patch locally, and it does have _an_ effect on the steps from
#1536 (running `Auto fix` with code containing multiple diagnostics selected):
* before, it would show a message saying no fixes are
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: Tor Shepherd (torshepherd)
Changes
This PR attempts to fix [1536.](https://github.com/clangd/clangd/issues/1536).
See in the unit tests, when all quick fixes are of the same `code`,
`isPreferred` will be true. However, this doesn't seem
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/torshepherd created
https://github.com/llvm/llvm-project/pull/79448
This PR attempts to fix [1536.](https://github.com/clangd/clangd/issues/1536).
See in the unit tests, when all quick fixes are of the same `code`,
`isPreferred` will be true. However, this doesn't seem to
