ckandeler wrote:
> If I'm understanding correctly, the implementation approach in this PR only
> finds callees in the current translation
> unit.
> The approach in #77556 uses the project's index to find callees across
> translation unit boundaries.
Right, that's obviously nicer.
>
HighCommander4 wrote:
If I'm understanding correctly, the implementation approach in this PR only
finds callees in the current translation unit.
The approach in #77556 uses the project's index to find callees across
translation unit boundaries.
Regarding reviews: yes, it seems quite
zyn0217 wrote:
> Seems nothing gets reviewed anymore these days.
Yeah, and unfortunately folks who are qualified/versed in clangd indices don't
have enough bandwidths recently, nor does the author @HighCommander4.
https://github.com/llvm/llvm-project/pull/91191
ckandeler wrote:
> I remembered @HighCommander4 had filed a similar PR at #77556. Is this one
> separate, or are they actually the same (i.e. both are salvaged from
> https://reviews.llvm.org/D93829)?
I didn't know about that one. Seems nothing gets reviewed anymore these days.
https://github.com/ckandeler closed
https://github.com/llvm/llvm-project/pull/91191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
I remembered @HighCommander4 had filed a similar PR at
https://github.com/llvm/llvm-project/pull/77556. Is this one separate, or are
they actually the same (i.e. both are salvaged from
https://reviews.llvm.org/D93829)?
https://github.com/llvm/llvm-project/pull/91191
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
@llvm/pr-subscribers-clangd
Author: Christian Kandeler (ckandeler)
Changes
---
Patch is 23.27 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/91191.diff
7 Files Affected:
- (modified)
https://github.com/ckandeler created
https://github.com/llvm/llvm-project/pull/91191
None
>From d7cfeb6599fd507eed8935e452efd782fc3f0481 Mon Sep 17 00:00:00 2001
From: Christian Kandeler
Date: Tue, 30 Apr 2024 18:20:05 +0200
Subject: [PATCH] [clangd] Support callHierarchy/outgoingCalls
---
