zibi2 wrote:
> Hi @zibi2, sorry for missing the breakage in the buildbot.
> [ce2f642](https://github.com/llvm/llvm-project/commit/ce2f6423f0168e945b6f29aa40a3054c1abe22a9)
> should fix it.
Thank you for a quick fix. I confirm the fix resolved the issue.
kadircet wrote:
Hi @zibi2, sorry for missing the breakage in the buildbot. ce2f6423f016 should
fix it.
https://github.com/llvm/llvm-project/pull/88381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zibi2 wrote:
@kadircet FYI, I noticed our Linux on Power down stream build failues related
to this change. The upstream builds are also faling see
https://lab.llvm.org/buildbot/#/builders/57/builds/34415 for example.
```
ld.lld: error: undefined symbol: llvm::Triple::getArchName() const
>>>
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/88381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/88381
From a99cb340ec6ede680a2b4d278b48d6062c42bef5 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Thu, 11 Apr 2024 14:02:43 +0200
Subject: [PATCH] [clangd] Use TargetOpts from preamble when building ASTs
https://github.com/sam-mccall approved this pull request.
https://github.com/llvm/llvm-project/pull/88381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -112,7 +112,10 @@ struct UpdateIndexCallbacks : public ParsingCallbacks {
// Index outlives TUScheduler (declared first)
FIndex(FIndex),
// shared_ptr extends lifetime
- Stdlib(Stdlib)]() mutable {
+
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/88381
From d747d817b6df04c8b93b7f89379448e467f0a0cd Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Thu, 11 Apr 2024 14:02:43 +0200
Subject: [PATCH] [clangd] Use TargetOpts from preamble when building ASTs
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/88381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov wrote:
All good from my side, but asked @sam-mccall or @usx95 to check the context
propagation bit as I'm missing context to make sure it's correct.
https://github.com/llvm/llvm-project/pull/88381
___
cfe-commits mailing list
@@ -112,7 +112,10 @@ struct UpdateIndexCallbacks : public ParsingCallbacks {
// Index outlives TUScheduler (declared first)
FIndex(FIndex),
// shared_ptr extends lifetime
- Stdlib(Stdlib)]() mutable {
+
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/88381
From 233f413b5921ff23c171fa5ada5623ad1a8e3d82 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Thu, 4 Apr 2024 10:57:44 +0200
Subject: [PATCH 1/2] [clangd] Propagate context into stdlib indexing thread
kadircet wrote:
> Just to confirm I understand the broader context: we only need it when
> building the AST because the rest of the code (completions, signature help)
> actually already uses a compile command and FS from preamble inputs, right?
That was my remembrance, but apparently it was
@@ -768,6 +764,35 @@ TEST(ParsedASTTest, GracefulFailureOnAssemblyFile) {
<< "Should not try to build AST for assembly source file";
}
+TEST(ParsedASTTest, PreambleWithDifferentTarget) {
+ constexpr std::string_view kPreambleTarget = "x86_64";
kadircet
@@ -451,6 +451,7 @@ ParsedAST::build(llvm::StringRef Filename, const
ParseInputs ,
DiagnosticConsumer *DiagConsumer =
IgnoreDiagnostics DropDiags;
if (Preamble) {
+CI->TargetOpts = Preamble->TargetOpts;
Patch = PreamblePatch::createFullPatch(Filename, Inputs,
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/88381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -768,6 +764,35 @@ TEST(ParsedASTTest, GracefulFailureOnAssemblyFile) {
<< "Should not try to build AST for assembly source file";
}
+TEST(ParsedASTTest, PreambleWithDifferentTarget) {
+ constexpr std::string_view kPreambleTarget = "x86_64";
https://github.com/ilya-biryukov commented:
Just to confirm I understand the broader context: we only need it when building
the AST because the rest of the code (completions, signature help) actually
already uses a compile command and FS from preamble inputs, right
@@ -451,6 +451,7 @@ ParsedAST::build(llvm::StringRef Filename, const
ParseInputs ,
DiagnosticConsumer *DiagConsumer =
IgnoreDiagnostics DropDiags;
if (Preamble) {
+CI->TargetOpts = Preamble->TargetOpts;
ilya-biryukov wrote:
It'd be useful to add a
@@ -451,6 +451,7 @@ ParsedAST::build(llvm::StringRef Filename, const
ParseInputs ,
DiagnosticConsumer *DiagConsumer =
IgnoreDiagnostics DropDiags;
if (Preamble) {
+CI->TargetOpts = Preamble->TargetOpts;
Patch = PreamblePatch::createFullPatch(Filename, Inputs,
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/88381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: kadir çetinkaya (kadircet)
Changes
Building ASTs with compile flags that are incompatible to the ones used
for the Preamble are not really supported by clang and can trigger
crashes.
In an ideal world, we should be re-using not only
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/88381
Building ASTs with compile flags that are incompatible to the ones used
for the Preamble are not really supported by clang and can trigger
crashes.
In an ideal world, we should be re-using not only TargetOpts,
23 matches
Mail list logo
