5chmidti wrote:
I'm closing this because it is not a good way to solve this. IMO, a good
approach would be to let users write the diagnostic severity they want to have
for all or for specific diagnostics groups in their clangd config file (like
described above). I've opened clangd/clangd#1937
https://github.com/5chmidti closed
https://github.com/llvm/llvm-project/pull/75706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
marzojr wrote:
Coming from the issue I posted on `vscode-clangd`, I think it was a bad
decision to make `modernize-*` checks basically disappear from the GUI. I feel
less strongly with regards to `misc-unused-*` checks, but it is probably also
true for those.
While trying to remove clutter
5chmidti wrote:
There is also the use-case to keep a relatively modern code-base in a modern
state. In that case, the user might want to know about
modernizations/deprecations right in the editor.
Example (vscode):
HighCommander4 wrote:
> You mentioned `inconsistencies`, is it inside clangd or in other places that
> surface clang-tidy findings?
I understood it as, the appearance of `modernize-*` clang-tidy diagnostics in
the editor is not consistent with the appearance of other (non-`modernize-*`)
kadircet wrote:
hi @5chmidti and @HighCommander4!
it was deliberate to cover `modernize-` checks as they're pretty similar to
`-wdeprecated` in nature, and they're both explicit, user needs to annotate
code or opt-in for particular clang-tidy checks.
feedback we received in the past was,
HighCommander4 wrote:
> Explicitly pinging @kadircet and @sam-mccall for your involvement in the
> mentioned commit. What are your thoughts on this? I looked into this because
> someone on discord asked about this difference.
Added Sam and Kadir as reviewers.
This patch seems to contradict
@@ -1811,10 +1811,10 @@ TEST(ParsedASTTest, ModuleSawDiag) {
TestTU TU;
auto AST = TU.build();
-#if 0
+#if 0
5chmidti wrote:
This formatting change slipped through, should I remove it?
https://github.com/llvm/llvm-project/pull/75706
5chmidti wrote:
The tag for `modernize-*` checks gets added here:
https://github.com/llvm/llvm-project/blob/f49e2b05bf3ececa2fe20c5d658ab92ab974dc36/clang-tools-extra/clangd/Diagnostics.cpp#L392-L397
https://github.com/llvm/llvm-project/pull/75706
___
5chmidti wrote:
Explicitly pinging @kadircet and @sam-mccall for your involvement in the
mentioned commit. What are your thoughts on this? I looked into this because
someone on discord asked about this difference.
https://github.com/llvm/llvm-project/pull/75706
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: Julian Schmidt (5chmidti)
Changes
Starting with a59b24be47ed6263c254d168567b9ebba391fac9, the severity of
diagnostics that have the 'Deprecated' tag is lowered to 'Remark'.
Because the `Deprecated` tag is applied to clang-tidy checks in
https://github.com/5chmidti created
https://github.com/llvm/llvm-project/pull/75706
Starting with a59b24be47ed6263c254d168567b9ebba391fac9, the severity of
diagnostics that have the 'Deprecated' tag is lowered to 'Remark'.
Because the `Deprecated` tag is applied to clang-tidy checks in
the
12 matches
Mail list logo
