https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/67023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/67023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danlark1 wrote:
@ldionne, CI is green, please, merge
Thanks for the feedback to everyone!
https://github.com/llvm/llvm-project/pull/67023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/danlark1 updated
https://github.com/llvm/llvm-project/pull/67023
>From 059bbfab50592026ce2785c5f7d98eaf5c9f8bd6 Mon Sep 17 00:00:00 2001
From: Daniel Kutenin
Date: Thu, 21 Sep 2023 14:55:11 +0100
Subject: [PATCH 1/7] Add bound checking in nth_element
---
philnik777 wrote:
You can use `// NOLINT(check-name)` or `// NOLINTNEXTLINE(check-name)` to
disable clang-tidy warnings. I would probably put a `//
NOLINTNEXTLINE(readability-function-cognitive-complexity)` above the function.
https://github.com/llvm/llvm-project/pull/67023
ldionne wrote:
> That depends on what we want to do with these kinds of issues in general. I
> think we should avoid making functions so complex. If we have a general
> consensus there, I think we should just suppress the warning with a todo that
> the function should be split up (or
danlark1 wrote:
>Also @danlark1 if you rebase onto main the issues with macOS in the CI should
>be fixed now.
@ldionne, Done
https://github.com/llvm/llvm-project/pull/67023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/danlark1 updated
https://github.com/llvm/llvm-project/pull/67023
>From 059bbfab50592026ce2785c5f7d98eaf5c9f8bd6 Mon Sep 17 00:00:00 2001
From: Daniel Kutenin
Date: Thu, 21 Sep 2023 14:55:11 +0100
Subject: [PATCH 1/6] Add bound checking in nth_element
---
