goldsteinn wrote:
For my money this was merged prematurely. There are still outstanding concerns
about whether this transform is desirable, as well there is an outstanding
comment about the implementation itself.
I'm fairly agnostic about this code getting in, but I think it should be
HaohaiWen wrote:
I'd like to merge it. Please let me know if you have more concern.
https://github.com/llvm/llvm-project/pull/68502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2727,105 +2727,161 @@ Instruction
*InstCombinerImpl::matchBSwapOrBitReverse(Instruction ,
}
/// Match UB-safe variants of the funnel shift intrinsic.
-static Instruction *matchFunnelShift(Instruction , InstCombinerImpl ) {
+static Instruction
HaohaiWen wrote:
> Yes, I understand that this transform is only a step towards handling the
> full pattern. I'm asking for a complete, working example of the original
> motivating case. The snippets posted in [#68502
>
HaohaiWen wrote:
I'd like to merge it if no any more comments.
https://github.com/llvm/llvm-project/pull/68502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HaohaiWen wrote:
> > Any more comments? I'd like to merge it if no objection.
>
> I think there are outstanding objections, or at least blocking concerns from
> nikic.
gentle ping @nikic
https://github.com/llvm/llvm-project/pull/68502
___
