Author: Simon Pilgrim Date: 2022-02-12T10:41:43Z New Revision: 389bee71ea71bf5a36e3786d3f60d3aa62e30be3
URL: https://github.com/llvm/llvm-project/commit/389bee71ea71bf5a36e3786d3f60d3aa62e30be3 DIFF: https://github.com/llvm/llvm-project/commit/389bee71ea71bf5a36e3786d3f60d3aa62e30be3.diff LOG: [clang-tidy] checkOverridingFunctionReturnType - use castAs<> instead of getAs<> to avoid dereference of nullptr The pointers are referenced immediately, so assert the cast is correct instead of returning nullptr Added: Modified: clang-tools-extra/clang-tidy/bugprone/VirtualNearMissCheck.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clang-tidy/bugprone/VirtualNearMissCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/VirtualNearMissCheck.cpp index 150b517811b66..f2aeac2430958 100644 --- a/clang-tools-extra/clang-tidy/bugprone/VirtualNearMissCheck.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/VirtualNearMissCheck.cpp @@ -40,11 +40,11 @@ static bool checkOverridingFunctionReturnType(const ASTContext *Context, const CXXMethodDecl *BaseMD, const CXXMethodDecl *DerivedMD) { QualType BaseReturnTy = BaseMD->getType() - ->getAs<FunctionType>() + ->castAs<FunctionType>() ->getReturnType() .getCanonicalType(); QualType DerivedReturnTy = DerivedMD->getType() - ->getAs<FunctionType>() + ->castAs<FunctionType>() ->getReturnType() .getCanonicalType(); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
