https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/69102
>From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 15 Oct 2023 11:39:42 +0100
Subject: [PATCH 1/9] Fix #35272: Don't replace typedefs in extern c scope
---
@@ -318,7 +318,8 @@ Changes in existing checks
- Improved :doc:`modernize-use-using
` check to fix function pointer and
- forward declared ``typedef`` correctly.
+ forward declared ``typedef`` correctly. Ignore ``typedef`` declaration in
PiotrZSL wrote:
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/69102
>From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 15 Oct 2023 11:39:42 +0100
Subject: [PATCH 1/7] Fix #35272: Don't replace typedefs in extern c scope
---
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/69102
>From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 15 Oct 2023 11:39:42 +0100
Subject: [PATCH 1/6] Fix #35272: Don't replace typedefs in extern c scope
---
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/69102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -28,6 +28,13 @@ After:
using R_t = struct { int a; };
using R_p = R_t*;
+The checker ignores `typedef` within `extern "C" { ... }` blocks.
+
+.. code-block:: c++
+ extern "C" {
PiotrZSL wrote:
put empty line here, this is why documentation fails
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/69102
>From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 15 Oct 2023 11:39:42 +0100
Subject: [PATCH 1/3] Fix #35272: Don't replace typedefs in extern c scope
---
@@ -28,6 +28,15 @@ After:
using R_t = struct { int a; };
using R_p = R_t*;
+The checker ignores `typedef` within `extern "C" { ... }` blocks.
PiotrZSL wrote:
I think so, for example I would like to enable this for my projects.
Ignoring extern "C" makes
@@ -285,6 +285,10 @@ Changes in existing checks
` check to fix function pointer and
forward declared ``typedef`` correctly.
+- Improved :doc:`modernize-use-using
Da-Viper wrote:
done
https://github.com/llvm/llvm-project/pull/69102
@@ -28,6 +28,15 @@ After:
using R_t = struct { int a; };
using R_p = R_t*;
+The checker ignores `typedef` within `extern "C" { ... }` blocks.
+
+.. code-block:: c++
+
+ extern "C" {
+
Da-Viper wrote:
done
https://github.com/llvm/llvm-project/pull/69102
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/69102
>From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 15 Oct 2023 11:39:42 +0100
Subject: [PATCH 1/3] Fix #35272: Don't replace typedefs in extern c scope
---
@@ -28,6 +28,15 @@ After:
using R_t = struct { int a; };
using R_p = R_t*;
+The checker ignores `typedef` within `extern "C" { ... }` blocks.
Da-Viper wrote:
Would it be preferred to make this an option ?
https://github.com/llvm/llvm-project/pull/69102
@@ -28,6 +28,15 @@ After:
using R_t = struct { int a; };
using R_p = R_t*;
+The checker ignores `typedef` within `extern "C" { ... }` blocks.
PiotrZSL wrote:
Maybe this should be put into configuration option ? To give an option to
preserve current
@@ -28,6 +28,15 @@ After:
using R_t = struct { int a; };
using R_p = R_t*;
+The checker ignores `typedef` within `extern "C" { ... }` blocks.
+
+.. code-block:: c++
+
+ extern "C" {
+
PiotrZSL wrote:
remove empty line
@@ -325,6 +329,7 @@ Changes in existing checks
identify calls to static member functions with out-of-class inline
definitions.
+
PiotrZSL wrote:
remove added empty line
https://github.com/llvm/llvm-project/pull/69102
@@ -285,6 +285,10 @@ Changes in existing checks
` check to fix function pointer and
forward declared ``typedef`` correctly.
+- Improved :doc:`modernize-use-using
PiotrZSL wrote:
merge with previous entry for this check.
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/69102
>From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 15 Oct 2023 11:39:42 +0100
Subject: [PATCH 1/2] Fix #35272: Don't replace typedefs in extern c scope
---
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/69102
>From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 15 Oct 2023 11:39:42 +0100
Subject: [PATCH 1/2] Fix #35272: Don't replace typedefs in extern c scope
---
PiotrZSL wrote:
> 2. where do I find the release notes.
clang-tools-extra/docs/ReleaseNotes.rst
https://github.com/llvm/llvm-project/pull/69102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Da-Viper wrote:
Ok, I do have a few questions.
1. Currently this check does not match typedefs in functions regardless of
extern c.should this be the case.
2. where do I find the release notes.
On Sun, 15 Oct 2023, 13:36 Piotr Zegar, ***@***.***> wrote:
> I got mixed feelings about this.
PiotrZSL wrote:
I got mixed feelings about this. Simply we can use 'using' within extern "C",
there is nothing wrong with this. using/typedef doesn't haven linkage, that
just type alias. And extern "C" does not impact it. In oryginal issue I think
someone mistook extern "C" into something
https://github.com/HerrCai0907 commented:
please update release note and doc
https://github.com/llvm/llvm-project/pull/69102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: None (Da-Viper)
Changes
Fixes #35272
---
Full diff: https://github.com/llvm/llvm-project/pull/69102.diff
2 Files Affected:
- (modified) clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp (+12-4)
- (modified)
https://github.com/Da-Viper created
https://github.com/llvm/llvm-project/pull/69102
Fixes #35272
>From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 15 Oct 2023 11:39:42 +0100
Subject: [PATCH] Fix #35272: Don't replace typedefs in extern c
24 matches
Mail list logo
