https://github.com/PeterChou1 edited
https://github.com/llvm/llvm-project/pull/93281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,48 +1,22 @@
-// Append using posix-style a file name or directory to Base
-function append(Base, New) {
- if (!New)
-return Base;
- if (Base)
-Base += "/";
- Base += New;
- return Base;
-}
-
-// Get relative path to access FilePath from CurrentDirectory
https://github.com/ilovepi requested changes to this pull request.
I'm not completely sure we want to use absolute paths, but since this mostly
seems related to URLs and not file system paths, its probably fine.
Please add some tests for this. It's preferable if we can pre-commit tests with
@@ -1,48 +1,22 @@
-// Append using posix-style a file name or directory to Base
-function append(Base, New) {
- if (!New)
-return Base;
- if (Base)
-Base += "/";
- Base += New;
- return Base;
-}
-
-// Get relative path to access FilePath from CurrentDirectory
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/93281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/93281
>From f5872e7c82d097ae3c141765d3f1d7e3d0b25b82 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Fri, 24 May 2024 04:28:08 -0400
Subject: [PATCH 1/2] clang-doc switched from using relative to absolute paths
---
https://github.com/PeterChou1 updated
https://github.com/llvm/llvm-project/pull/93281
>From f5872e7c82d097ae3c141765d3f1d7e3d0b25b82 Mon Sep 17 00:00:00 2001
From: PeterChou1
Date: Fri, 24 May 2024 04:28:08 -0400
Subject: [PATCH 1/2] clang-doc switched from using relative to absolute paths
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: None (PeterChou1)
Changes
issue: https://github.com/llvm/llvm-project/issues/92867
I solved the problem by making the js use absolute path instead relative I
think this also makes it more permanent since there is no need to
https://github.com/PeterChou1 created
https://github.com/llvm/llvm-project/pull/93281
issue: https://github.com/llvm/llvm-project/issues/92867
I solved the problem by making the js use absolute path instead relative I
think this also makes it more permanent since there is no need to compute
