Re: [clang-tools-extra] r311020 - [clang-tidy] Use CloexecCheck as base class.

2017-08-16 Thread Chih-hung Hsieh via cfe-commits
Thanks. The fix is in https://reviews.llvm.org/rL311040. On Wed, Aug 16, 2017 at 1:39 PM, Evgenii Stepanov wrote: > Hi, > > this change breaks build: > clang-tools-extra/clang-tidy/android/CloexecSocketCheck.cpp:20:30: > error: unused variable 'SOCK_CLOEXEC' >

Re: [clang-tools-extra] r311020 - [clang-tidy] Use CloexecCheck as base class.

2017-08-16 Thread Evgenii Stepanov via cfe-commits
Hi, this change breaks build: clang-tools-extra/clang-tidy/android/CloexecSocketCheck.cpp:20:30: error: unused variable 'SOCK_CLOEXEC' [-Werror,-Wunused-const-variable] static constexpr const char *SOCK_CLOEXEC = "SOCK_CLOEXEC"; Please test with LLVM_ENABLE_WERROR=ON before submitting! On Wed,

[clang-tools-extra] r311020 - [clang-tidy] Use CloexecCheck as base class.

2017-08-16 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Wed Aug 16 09:59:26 2017 New Revision: 311020 URL: http://llvm.org/viewvc/llvm-project?rev=311020=rev Log: [clang-tidy] Use CloexecCheck as base class. Summary: Simplify registerMatchers and check functions in CloexecCreatCheck, CloexecSocketCheck, CloexecFopenCheck, and