Re: [clang-tools-extra] r315060 - Renaming a test to start with the name of the check based on post-commit review feedback; NFC.

2017-10-12 Thread Jonas Toth via cfe-commits
Ok. I subscribe to r315057. I can look at debugging the change as well if you guys want. Should have time today evening and tomorrow. Am 12.10.2017 um 12:46 schrieb Alexander Kornienko: On Thu, Oct 12, 2017 at 11:12 AM, Jonas Toth > wrote: Hi, I am not

Re: [clang-tools-extra] r315060 - Renaming a test to start with the name of the check based on post-commit review feedback; NFC.

2017-10-12 Thread Alexander Kornienko via cfe-commits
On Thu, Oct 12, 2017 at 11:12 AM, Jonas Toth wrote: > Hi, > > I am not sure if could follow correctly, but the test for nested > namespaces comments does not work correctly and is therefore currently > disabled by fileextension? > No, the removal of the file extension was unintentional (likely m

Re: [clang-tools-extra] r315060 - Renaming a test to start with the name of the check based on post-commit review feedback; NFC.

2017-10-12 Thread Jonas Toth via cfe-commits
Hi, I am not sure if could follow correctly, but the test for nested namespaces comments does not work correctly and is therefore currently disabled by fileextension? When running the check from trunk i get the following issues: $ clang-check google-readability-namespace-comments-cxx17.cpp -

Re: [clang-tools-extra] r315060 - Renaming a test to start with the name of the check based on post-commit review feedback; NFC.

2017-10-11 Thread Aaron Ballman via cfe-commits
On Wed, Oct 11, 2017 at 3:29 PM, Alexander Kornienko wrote: > On Fri, Oct 6, 2017 at 3:27 PM, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Fri Oct 6 06:27:59 2017 >> New Revision: 315060 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=315060&view=rev >> Log: >> R

Re: [clang-tools-extra] r315060 - Renaming a test to start with the name of the check based on post-commit review feedback; NFC.

2017-10-11 Thread Alexander Kornienko via cfe-commits
On Fri, Oct 6, 2017 at 3:27 PM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Fri Oct 6 06:27:59 2017 > New Revision: 315060 > > URL: http://llvm.org/viewvc/llvm-project?rev=315060&view=rev > Log: > Renaming a test to start with the name of the

[clang-tools-extra] r315060 - Renaming a test to start with the name of the check based on post-commit review feedback; NFC.

2017-10-06 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri Oct 6 06:27:59 2017 New Revision: 315060 URL: http://llvm.org/viewvc/llvm-project?rev=315060&view=rev Log: Renaming a test to start with the name of the check based on post-commit review feedback; NFC. Added: clang-tools-extra/trunk/test/clang-tidy/google-rea