Re: [clang-tools-extra] r343576 - [clangd] Cache FS stat() calls when building preamble.

2018-10-02 Thread Mikael Holmén via cfe-commits
Hi Eric, I fixed a compilation warning introduced with this patch in r343661. Regards, Mikael On 10/02/2018 12:43 PM, Eric Liu via cfe-commits wrote: Author: ioeric Date: Tue Oct 2 03:43:55 2018 New Revision: 343576 URL: http://llvm.org/viewvc/llvm-project?rev=343576&view=rev Log: [clangd] C

Re: [clang-tools-extra] r343576 - [clangd] Cache FS stat() calls when building preamble.

2018-10-02 Thread Eric Liu via cfe-commits
>> >> Code complete: sema context Statement, query scopes [] (AnyScope=false) >> >> Code complete: 1 results from Sema, 0 from Index, 0 matched, 1 returned. >> >> >> >> Can you please take a look? >> >> Douglas Yung &g

Re: [clang-tools-extra] r343576 - [clangd] Cache FS stat() calls when building preamble.

2018-10-02 Thread Eric Liu via cfe-commits
from Index, 0 matched, 1 returned. > > > > Can you please take a look? > > Douglas Yung > > > -----Original Message----- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > > Of Eric Liu via cfe-commits > >

RE: [clang-tools-extra] r343576 - [clangd] Cache FS stat() calls when building preamble.

2018-10-02 Thread via cfe-commits
October 02, 2018 3:44 > To: cfe-commits@lists.llvm.org > Subject: [clang-tools-extra] r343576 - [clangd] Cache FS stat() calls > when building preamble. > > Author: ioeric > Date: Tue Oct 2 03:43:55 2018 > New Revision: 343576 > > URL: http://llvm.org/viewvc/llvm-

[clang-tools-extra] r343576 - [clangd] Cache FS stat() calls when building preamble.

2018-10-02 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Oct 2 03:43:55 2018 New Revision: 343576 URL: http://llvm.org/viewvc/llvm-project?rev=343576&view=rev Log: [clangd] Cache FS stat() calls when building preamble. Summary: The file stats can be reused when preamble is reused (e.g. code completion). It's safe to assume tha