petrhosek wrote:
> > What I think would be a better design is to just omit the respective
> > sections altogether when -debug-info-correlate/-profile-correlate= is
> > enabled.
>
> I don't understand how this solves the problem you described above. Can you
> elaborate a bit more? We still
ZequanWu wrote:
> I'm a bit concerned about the use of hasCorrelation. We require the runtime
> to check the flag and omit the data and names section if set which introduces
> a potential issue: since we emit the version in every TU and u se COMDAT to
> deduplicate them, but that means that
@@ -89,3 +89,7 @@ COMPILER_RT_VISIBILITY void
__llvm_profile_reset_counters(void) {
}
lprofSetProfileDumped(0);
}
+
+inline int hasCorrelation() {
ZequanWu wrote:
COMPILER_RT_VISIBILITY is added at
dtellenbach wrote:
> It should be fixed by
> [56e205a](https://github.com/llvm/llvm-project/commit/56e205a89cbb114750f2bd3f5cfbd19e209d018a).
Thank you!
https://github.com/llvm/llvm-project/pull/70856
___
cfe-commits mailing list
ZequanWu wrote:
> @ZequanWu this seems to cause issues on macOS:
> https://green.lab.llvm.org/green/job/clang-stage1-RA/36184/console
>
> ```
> Profile-x86_64 :: Darwin/instrprof-debug-info-correlate.c
> Profile-x86_64 :: instrprof-darwin-
> Profile-x86_64h ::
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/70856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ellishg approved this pull request.
Sounds fine to me, but I guess I don't understand why `-profile-correlate=`
doesn't work. Do you still plan to add the flag later?
https://github.com/llvm/llvm-project/pull/70856
___
cfe-commits
