[flang] [clang] [flang] Add depdendent-lib option to flang -fc1 on Windows (PR #72121)

https://github.com/DavidTruby updated https://github.com/llvm/llvm-project/pull/72121 >From cfd46a8825aa34b3e513d898ceb57f4e48e78faf Mon Sep 17 00:00:00 2001 From: David Truby Date: Mon, 13 Nov 2023 14:48:44 + Subject: [PATCH 1/3] [flang] Add depdendent-lib option to flang -fc1 on Windows

[flang] [clang] [flang] Add depdendent-lib option to flang -fc1 on Windows (PR #72121)

@@ -0,0 +1,15 @@ +! DEFINE: %{triple} = +! DEFINE: %{run} = %flang_fc1 -emit-mlir -triple %{triple} --dependent-lib=libtest %s -o - 2>&1 | FileCheck %s +! REDEFINE: %{triple} = aarch64-pc-windows-msvc +! RUN: %{run} +! REDEFINE: %{triple} = x86_64-pc-windows-msvc +! RUN: %{run} +

[flang] [clang] [flang] Add depdendent-lib option to flang -fc1 on Windows (PR #72121)

https://github.com/banach-space approved this pull request. LGTM :) Thank you for addressing my comments. https://github.com/llvm/llvm-project/pull/72121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[flang] [clang] [flang] Add depdendent-lib option to flang -fc1 on Windows (PR #72121)

@@ -0,0 +1,7 @@ + +! RUN: %flang_fc1 -emit-mlir -triple aarch64-pc-windows-msvc --dependent-lib=libtest %s -o - 2>&1 | FileCheck %s +! RUN: %flang_fc1 -emit-mlir -triple x86_64-pc-windows-msvc --dependent-lib=libtest %s -o - 2>&1 | FileCheck %s DavidTruby wrote:

[flang] [clang] [flang] Add depdendent-lib option to flang -fc1 on Windows (PR #72121)

https://github.com/DavidTruby edited https://github.com/llvm/llvm-project/pull/72121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [flang] Add depdendent-lib option to flang -fc1 on Windows (PR #72121)

@@ -0,0 +1,7 @@ + banach-space wrote: [nit] This line can be skipped? https://github.com/llvm/llvm-project/pull/72121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[flang] [clang] [flang] Add depdendent-lib option to flang -fc1 on Windows (PR #72121)

@@ -303,6 +323,9 @@ bool CodeGenAction::beginSourceFileAction() { Fortran::parser::Program &parseTree{*ci.getParsing().parseTree()}; lb.lower(parseTree, ci.getInvocation().getSemanticsContext()); + // Add dependent libraries + addDepdendentLibs(*mlirModule, ci);

[flang] [clang] [flang] Add depdendent-lib option to flang -fc1 on Windows (PR #72121)

@@ -0,0 +1,7 @@ + +! RUN: %flang_fc1 -emit-mlir -triple aarch64-pc-windows-msvc --dependent-lib=libtest %s -o - 2>&1 | FileCheck %s +! RUN: %flang_fc1 -emit-mlir -triple x86_64-pc-windows-msvc --dependent-lib=libtest %s -o - 2>&1 | FileCheck %s banach-space wrot

[flang] [clang] [flang] Add depdendent-lib option to flang -fc1 on Windows (PR #72121)

https://github.com/banach-space commented: Great to see contributions for supporting Windows, thank you David! https://github.com/llvm/llvm-project/pull/72121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[flang] [clang] [flang] Add depdendent-lib option to flang -fc1 on Windows (PR #72121)

@@ -0,0 +1,7 @@ + +! RUN: %flang_fc1 -emit-mlir -triple aarch64-pc-windows-msvc --dependent-lib=libtest %s -o - 2>&1 | FileCheck %s +! RUN: %flang_fc1 -emit-mlir -triple x86_64-pc-windows-msvc --dependent-lib=libtest %s -o - 2>&1 | FileCheck %s + +! CHECK: llvm.linker_options ["

[flang] [clang] [flang] Add depdendent-lib option to flang -fc1 on Windows (PR #72121)

@@ -1054,6 +1054,27 @@ static bool parseVScaleArgs(CompilerInvocation &invoc, llvm::opt::ArgList &args, return true; } +static bool parseLinkerOptionsArgs(CompilerInvocation &invoc, + llvm::opt::ArgList &args, +

[flang] [clang] [flang] Add depdendent-lib option to flang -fc1 on Windows (PR #72121)

llvmbot wrote: @llvm/pr-subscribers-clang Author: David Truby (DavidTruby) Changes This patch adds a --depdendent-lib option to flang -fc1 on Windows to embed library link options into the object file. This is needed to properly select the Windows CRT to link against. --- Full diff: https

[flang] [clang] [flang] Add depdendent-lib option to flang -fc1 on Windows (PR #72121)

https://github.com/DavidTruby created https://github.com/llvm/llvm-project/pull/72121 This patch adds a --depdendent-lib option to flang -fc1 on Windows to embed library link options into the object file. This is needed to properly select the Windows CRT to link against. >From cfd46a8825aa34b3e