[libcxx] r250003 - [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed.

Author: cbieneman Date: Sun Oct 11 19:49:56 2015 New Revision: 250003 URL: http://llvm.org/viewvc/llvm-project?rev=250003=rev Log: [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed. This mirrors how other LLVM suites

Re: [libcxx] r250003 - [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed.

Do we need to do with while building libc++ as well? Also please reuse lit.util.capture or lit.util.executeCommand instead of subprocess. /Eric On Sun, Oct 11, 2015 at 6:49 PM, Chris Bieneman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: cbieneman > Date: Sun Oct 11 19:49:56

Re: [libcxx] r250003 - [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed.

CMake handles doing it while building. I will update to use lit.util.* -Chris > On Oct 11, 2015, at 6:04 PM, Eric Fiselier wrote: > > Do we need to do with while building libc++ as well? Also please reuse > lit.util.capture or lit.util.executeCommand instead of subprocess. > >

Re: [libcxx] r250003 - [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed.

Updated in r250007. -Chris > On Oct 11, 2015, at 7:49 PM, Chris Bieneman via cfe-commits > wrote: > > CMake handles doing it while building. I will update to use lit.util.* > > -Chris > >> On Oct 11, 2015, at 6:04 PM, Eric Fiselier >