Re: [libcxx] r255177 - Remove visibility attributes from out-of-class method definitions in iostreams.

2016-01-08 Thread Evgenii Stepanov via cfe-commits
Reverted in r257193. On Fri, Jan 8, 2016 at 11:12 AM, Evgenii Stepanov wrote: > On Fri, Jan 8, 2016 at 11:02 AM, Duncan P. N. Exon Smith > wrote: >> >>> On 2016-Jan-08, at 10:49, Nico Weber via cfe-commits >>> wrote:

Re: [libcxx] r255177 - Remove visibility attributes from out-of-class method definitions in iostreams.

2016-01-08 Thread Nico Weber via cfe-commits
On OS X 10.8, __ZNSt3__115basic_streambufIcNS_11char_traitsIcEEE5sputcEc (and others) are a hidden symbol in libc++.1.dylib. This means: * If I use streambuf::sputc() and link against the 10.8 SDK, and the compiler decides to not inline the call, I will get linker errors. * If I do the same with

Re: [libcxx] r255177 - Remove visibility attributes from out-of-class method definitions in iostreams.

2016-01-08 Thread Evgenii Stepanov via cfe-commits
On Fri, Jan 8, 2016 at 11:02 AM, Duncan P. N. Exon Smith wrote: > >> On 2016-Jan-08, at 10:49, Nico Weber via cfe-commits >> wrote: >> >> On OS X 10.8, __ZNSt3__115basic_streambufIcNS_11char_traitsIcEEE5sputcEc >> (and others) are a hidden

Re: [libcxx] r255177 - Remove visibility attributes from out-of-class method definitions in iostreams.

2016-01-08 Thread Nico Weber via cfe-commits
Thank you! On Fri, Jan 8, 2016 at 2:24 PM, Evgenii Stepanov wrote: > Reverted in r257193. > > On Fri, Jan 8, 2016 at 11:12 AM, Evgenii Stepanov > wrote: > > On Fri, Jan 8, 2016 at 11:02 AM, Duncan P. N. Exon Smith > >

Re: [libcxx] r255177 - Remove visibility attributes from out-of-class method definitions in iostreams.

2016-01-08 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2016-Jan-08, at 10:49, Nico Weber via cfe-commits > wrote: > > On OS X 10.8, __ZNSt3__115basic_streambufIcNS_11char_traitsIcEEE5sputcEc (and > others) are a hidden symbol in libc++.1.dylib. This means: > > * If I use streambuf::sputc() and link against the

[libcxx] r255177 - Remove visibility attributes from out-of-class method definitions in iostreams.

2015-12-09 Thread Evgeniy Stepanov via cfe-commits
Author: eugenis Date: Wed Dec 9 17:42:30 2015 New Revision: 255177 URL: http://llvm.org/viewvc/llvm-project?rev=255177=rev Log: Remove visibility attributes from out-of-class method definitions in iostreams. No point in pretending that these methods are hidden - they are actually exported from