Re: [libcxx] r281179 - [libcxx] Introduce an externally-threaded libc++ variant.

2016-09-12 Thread Asiri Rathnayake via cfe-commits
Hi Mike, Can you check if https://reviews.llvm.org/D24475 fixes the issue for you? This looks like a bug in the gcc pre-processor (in older versions of gcc). I'm a bit hesitant because my gcc (4.8.3) bumps into a different issue (crash!) as well, but that seem to have nothing to do with my patch

Re: [libcxx] r281179 - [libcxx] Introduce an externally-threaded libc++ variant.

2016-09-12 Thread Asiri Rathnayake via cfe-commits
OK, I'm able to reproduce locally. Looks like gcc (4.8.3 at least) does not like my patch. Working on a fix... On Mon, Sep 12, 2016 at 9:43 PM, Asiri Rathnayake < asiri.rathnay...@gmail.com> wrote: > Hi Mike, > > That does look related to my change. Is this an internal build? I was > looking out

Re: [libcxx] r281179 - [libcxx] Introduce an externally-threaded libc++ variant.

2016-09-12 Thread Asiri Rathnayake via cfe-commits
Hi Mike, That does look related to my change. Is this an internal build? I was looking out for the bots on llvm.org but didn't spot any issues (yet). Will try to reproduce locally. Would it be OK if I find a fix tomorrow? (night time here in the UK), can revert if this is blocking you. Cheers,

Re: [libcxx] r281179 - [libcxx] Introduce an externally-threaded libc++ variant.

2016-09-12 Thread Mike Aizatsky via cfe-commits
Asiri, The boot strap build has started to fail for. Your change seems to be related, right? [14/22] Building CXX object projects/libcxx/lib/CMakeFiles/cxx_objects.dir/__/src/locale.cpp.o FAILED: /usr/bin/g++ -D_DEBUG -D_GNU_SOURCE -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D__STDC_CONSTANT_MACROS

[libcxx] r281179 - [libcxx] Introduce an externally-threaded libc++ variant.

2016-09-11 Thread Asiri Rathnayake via cfe-commits
Author: asiri Date: Sun Sep 11 16:46:40 2016 New Revision: 281179 URL: http://llvm.org/viewvc/llvm-project?rev=281179&view=rev Log: [libcxx] Introduce an externally-threaded libc++ variant. This patch further decouples libc++ from pthread, allowing libc++ to be built against other threading syste