Re: [libcxx] r291329 - Add _LIBCPP_ABI_[ITANIUM|MICROSOFT] macros.

2017-01-07 Thread Eric Fiselier via cfe-commits
On Sat, Jan 7, 2017 at 1:29 AM, Shoaib Meenai wrote: > Do you think it's worth also checking for the presence of cxxabi.h and > assuming the Itanium ABI if it's found, since the MS ABI shouldn't be using > any ABI library? > No I don't think we should check for `cxxabi.h`.It's

Re: [libcxx] r291329 - Add _LIBCPP_ABI_[ITANIUM|MICROSOFT] macros.

2017-01-07 Thread Shoaib Meenai via cfe-commits
Do you think it's worth also checking for the presence of cxxabi.h and assuming the Itanium ABI if it's found, since the MS ABI shouldn't be using any ABI library? (_LIBCPP_BUILDING_HAS_NO_ABI_LIBRARY would have been ideal were it available persistently rather than only during the build of libc++

[libcxx] r291329 - Add _LIBCPP_ABI_[ITANIUM|MICROSOFT] macros.

2017-01-06 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jan 6 20:43:58 2017 New Revision: 291329 URL: http://llvm.org/viewvc/llvm-project?rev=291329=rev Log: Add _LIBCPP_ABI_[ITANIUM|MICROSOFT] macros. This patch adds a libc++ configuration macro for the ABI we are targeting, either Itanium or Microsoft. For now we configure