Re: [libcxx] r294553 - [libcxx][CMake] Support in-tree libunwind when building as part of runtimes

2019-01-21 Thread Leslie Zhai via cfe-commits
在 2019/1/21 下午5:36, Leslie Zhai 写道: Hi Asiri, Did you fix the issue when building libcxx and libcxxabi use LLVM's libunwind? Fixed :) Just put libcxx, libcxxabi, libunwind and compiler-rt under `runtimes` directory. Leslie Zhai

Re: [libcxx] r294553 - [libcxx][CMake] Support in-tree libunwind when building as part of runtimes

2019-01-21 Thread Leslie Zhai via cfe-commits
Hi Asiri, Did you fix the issue when building libcxx and libcxxabi use LLVM's libunwind? http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20170206/184841.html I experienced the similar issue: CMake Error at projects/libcxxabi/src/CMakeLists.txt:163 (target_link_libraries):   Target

Re: [libcxx] r294553 - [libcxx][CMake] Support in-tree libunwind when building as part of runtimes

2017-02-09 Thread Asiri Rathnayake via cfe-commits
Ah, ignore me please. I should've read the patch. / Asiri On Thu, Feb 9, 2017 at 9:13 AM, Asiri Rathnayake wrote: > Hi Petr, > > This is breaking static builds of the libraries, cmake complaints with: > > "CMake Error at projects/libcxxabi/src/CMakeLists.txt:134 >

Re: [libcxx] r294553 - [libcxx][CMake] Support in-tree libunwind when building as part of runtimes

2017-02-09 Thread Asiri Rathnayake via cfe-commits
Hi Petr, This is breaking static builds of the libraries, cmake complaints with: "CMake Error at projects/libcxxabi/src/CMakeLists.txt:134 (target_link_libraries): Target "unwind" of type UTILITY may not be linked into another target. One may link only to STATIC or SHARED libraries, or to

[libcxx] r294553 - [libcxx][CMake] Support in-tree libunwind when building as part of runtimes

2017-02-08 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed Feb 8 20:19:43 2017 New Revision: 294553 URL: http://llvm.org/viewvc/llvm-project?rev=294553=rev Log: [libcxx][CMake] Support in-tree libunwind when building as part of runtimes When building as part of runtimes, there is no predefined order in which the runtimes are