Re: [libcxx] r309881 - Rename a couple variables to eliminate a shadow warning. No functionality change

2017-08-02 Thread Blitz Rakete via cfe-commits
Instead of creating two variables, wouldn't it be better to just remove the second definition and clear m_ec? You don't need to use both error codes side by side, as the second usage of m_ec occurs after the first one is finished. So you could remove the second definition and call clear() on it, to

[libcxx] r309881 - Rename a couple variables to eliminate a shadow warning. No functionality change

2017-08-02 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Aug 2 13:29:26 2017 New Revision: 309881 URL: http://llvm.org/viewvc/llvm-project?rev=309881&view=rev Log: Rename a couple variables to eliminate a shadow warning. No functionality change Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp Modified: