[libunwind] [runtimes] Fix link order of system librarires on Apple platforms (PR #66940)

2023-09-21 Thread Louis Dionne via cfe-commits
@@ -659,24 +659,22 @@ function(cxx_link_system_libraries target) target_add_link_flags_if_supported(${target} PRIVATE "--unwindlib=none") endif() - if (LIBCXX_HAS_SYSTEM_LIB) -target_link_libraries(${target} PRIVATE System) - endif() - - if

[libunwind] [runtimes] Fix link order of system librarires on Apple platforms (PR #66940)

2023-09-20 Thread via cfe-commits
@@ -659,24 +659,22 @@ function(cxx_link_system_libraries target) target_add_link_flags_if_supported(${target} PRIVATE "--unwindlib=none") endif() - if (LIBCXX_HAS_SYSTEM_LIB) -target_link_libraries(${target} PRIVATE System) - endif() - - if

[libunwind] [runtimes] Fix link order of system librarires on Apple platforms (PR #66940)

2023-09-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx Changes On Apple platforms, we always support the -nostdlib++ flag. Hence, it is not necessary to manually link against system libraries. In fact, doing so causes us to link against libSystem explicitly, which messes up with the order of

[libunwind] [runtimes] Fix link order of system librarires on Apple platforms (PR #66940)

2023-09-20 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/66940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Fix link order of system librarires on Apple platforms (PR #66940)

2023-09-20 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/66940 On Apple platforms, we always support the -nostdlib++ flag. Hence, it is not necessary to manually link against system libraries. In fact, doing so causes us to link against libSystem explicitly, which messes