ldionne wrote:
Not pursuing anymore, closing to clean up the queue.
https://github.com/llvm/llvm-project/pull/66265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/66265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo wrote:
> But even regardless of #67201, the intended way to use the libc++ test suite
> is to create a `.cfg.in` file that suits your needs if the general ones
> don't, not to add more configuration options to the general ones.
IMO, I think this is something I fundamentally disagree
petrhosek wrote:
> How do you build on Apple platforms then? Don't you need access to a SDK? I'm
> a bit confused about what you're doing -- do you need to use the native
> platform SDK when you're building Fuchsia? What SDK are you passing as
> `--sysroot` when testing libc++?
We use
petrhosek wrote:
> @petrhosek Please take a look -- this is passing CI and I believe this should
> support your use case. And it's definitely the way these configuration files
> should have been set up from the start, I guess I just didn't think of doing
> it that way when I hit the sysroot
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/66265:
>From dfca35edb3eb6c0cd2e7d3292f854dcd9bdc6cb7 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 13 Sep 2023 13:30:30 -0400
Subject: [PATCH] [runtimes] Remove explicit -isysroot from the testing
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/66265:
>From c325c0ba95e6d6abe7ff1a371853051bab0510af Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 13 Sep 2023 13:30:30 -0400
Subject: [PATCH] [runtimes] Remove explicit -isysroot from the testing
@@ -2,6 +2,24 @@
@SERIALIZED_LIT_PARAMS@
+# Workaround for https://gitlab.kitware.com/cmake/cmake/-/issues/19180.
+#
+# On Apple platforms, CMake resolves the compiler to the final binary using
+# `$(xcrun --find `). Unfortunately, running this compiler as-is
+# doesn't work
petrhosek wrote:
This is going to break our builds because we always use the just built Clang
(built using the bootstrap build) even on Darwin. I'm fine doing this change
for `apple-*.cfg.in` configurations to better match Apple configuration, but
for `llvm-*.cfg.in` I'd like to preserve the
llvmbot wrote:
@llvm/pr-subscribers-libunwind
Changes
This shouldn't be necessary if we set the SDKROOT environment variable properly
when we run the test suite, as it is expected on Apple platforms. To set the
SDKROOT environment variable properly, we have to use a slight
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne review_requested
https://github.com/llvm/llvm-project/pull/66265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne review_requested
https://github.com/llvm/llvm-project/pull/66265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne review_requested
https://github.com/llvm/llvm-project/pull/66265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/66265:
This shouldn't be necessary if we set the SDKROOT environment variable properly
when we run the test suite, as it is expected on Apple platforms. To set the
SDKROOT environment variable properly, we have to
17 matches
Mail list logo
