[llvm] [clang] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-14 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. LGTM modulo one small comment in the test. Thanks for getting this done so quickly. https://github.com/llvm/llvm-project/pull/75542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-14 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/75542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-14 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/75542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-14 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/75542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-14 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks updated https://github.com/llvm/llvm-project/pull/75542 >From 884347b73d68e2d469b3903f248e72921434 Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Thu, 14 Dec 2023 15:41:31 -0800 Subject: [PATCH 1/2] [Instrumentation][X86] Limit setting large section flag

[llvm] [clang] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-14 Thread Paul Kirth via cfe-commits
ilovepi wrote: well I guess I should say I thought it would be reliable rather than available, but I see why it wouldn't be. https://github.com/llvm/llvm-project/pull/75542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-14 Thread Paul Kirth via cfe-commits
ilovepi wrote: > Actually I'm going to go down the `Module::getCodeModel()` route. Right now I > think frontends adding module metadata for the code model is probably not > common, but we should aim for that. And this will in the short term still > work for Fuchsia without breaking API for

[llvm] [clang] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-14 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: Actually I'm going to go down the `Module::getCodeModel()` route. Right now I think frontends adding module metadata for the code model is probably not common, but we should aim for that. And this will in the short term still work for Fuchsia without breaking API for other

[llvm] [clang] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer Author: Arthur Eubanks (aeubanks) Changes In #74514 and #74778 we marked various instrumentation-added sections as large. This causes an extra PT_LOAD segment if using the small code model. Since people using the small code model

[llvm] [clang] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-14 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks created https://github.com/llvm/llvm-project/pull/75542 In #74514 and #74778 we marked various instrumentation-added sections as large. This causes an extra PT_LOAD segment if using the small code model. Since people using the small code model presumably aren't