https://github.com/bryanpkc closed
https://github.com/llvm/llvm-project/pull/75516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bryanpkc updated
https://github.com/llvm/llvm-project/pull/75516
>From a39cd3fba9cd8fb6757bfd297d57f6ab98b36405 Mon Sep 17 00:00:00 2001
From: Qi Hu
Date: Thu, 14 Dec 2023 13:35:52 -0500
Subject: [PATCH] [TargetParser] Define AEK_FCMA and AEK_JSCVT for tsv110
We define
https://github.com/davemgreen approved this pull request.
https://github.com/ARM-software/acle/pull/279 was committed recently, where I
think this lines up with the final version of it. I think this LGTM in that
case.
https://github.com/llvm/llvm-project/pull/75516
https://github.com/Qi-Hu updated https://github.com/llvm/llvm-project/pull/75516
>From 136471458682f393b15ed2807342a03309ed0b56 Mon Sep 17 00:00:00 2001
From: Qi Hu
Date: Thu, 14 Dec 2023 13:35:52 -0500
Subject: [PATCH] [TargetParser] Define AEK_FCMA and AEK_JSCVT for tsv110
We define
https://github.com/Qi-Hu updated https://github.com/llvm/llvm-project/pull/75516
>From 74f1a4ed5d9ea582867babc2cf502b12f5ed97d0 Mon Sep 17 00:00:00 2001
From: Qi Hu
Date: Thu, 14 Dec 2023 13:35:52 -0500
Subject: [PATCH] [TargetParser] Define AEK_FCMA and AEK_JSCVT for tsv110
We define
@@ -81,6 +81,15 @@ static bool DecodeAArch64Features(const Driver , StringRef
text,
else
return false;
+// +jsconv and +complxnum implies +neon and +fp-armv8
Qi-Hu wrote:
I have made some changes and included AEK_JSCVT and AEK_FCMA in
https://github.com/Qi-Hu updated https://github.com/llvm/llvm-project/pull/75516
>From 63d3b05cab2b9c72827d7dfffc53aa9fd6d9fe34 Mon Sep 17 00:00:00 2001
From: Qi Hu
Date: Thu, 14 Dec 2023 13:35:52 -0500
Subject: [PATCH] [TargetParser] Define AEK_FCMA and AEK_JSCVT for tsv110
We define
https://github.com/Qi-Hu updated https://github.com/llvm/llvm-project/pull/75516
>From e93dd2aa9005435b401d0ca3b1005768f8a636dd Mon Sep 17 00:00:00 2001
From: Qi Hu
Date: Thu, 14 Dec 2023 13:35:52 -0500
Subject: [PATCH] [TargetParser] Define AEK_FCMA and AEK_JSCVT for tsv110
We define
@@ -81,6 +81,15 @@ static bool DecodeAArch64Features(const Driver , StringRef
text,
else
return false;
+// +jsconv and +complxnum implies +neon and +fp-armv8
bryanpkc wrote:
@momchil-velikov Thank you for your answer. It is strange that the
@@ -173,6 +173,8 @@ enum ArchExtKind : unsigned {
AEK_SMEF8F16 = 69, // FEAT_SME_F8F16
AEK_SMEF8F32 = 70, // FEAT_SME_F8F32
AEK_SMEFA64 = 71, // FEAT_SME_FA64
+ AEK_JSCVT = 72, // FEAT_JSCVT
+ AEK_FCMA = 73, // FEAT_FCMA
@@ -81,6 +81,15 @@ static bool DecodeAArch64Features(const Driver , StringRef
text,
else
return false;
+// +jsconv and +complxnum implies +neon and +fp-armv8
momchil-velikov wrote:
According to the latest Arm ARM
@@ -81,6 +81,15 @@ static bool DecodeAArch64Features(const Driver , StringRef
text,
else
return false;
+// +jsconv and +complxnum implies +neon and +fp-armv8
Qi-Hu wrote:
The dependencies between these new target attributes and others are also
@@ -81,6 +81,15 @@ static bool DecodeAArch64Features(const Driver , StringRef
text,
else
return false;
+// +jsconv and +complxnum implies +neon and +fp-armv8
ilinpv wrote:
I don't think we need these implications. Features dependencies are
https://github.com/bryanpkc approved this pull request.
This looks reasonable to me, but I'll wait for other reviewers to look at this.
Please rebase on main and make sure the CI workflows succeed.
https://github.com/llvm/llvm-project/pull/75516
___
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff fed564432cef76f8b303c19ab1dfc0a14878fbc3
6a1ac6f738459658690e7436820292fc28397ee4 --
15 matches
Mail list logo
