Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

2019-05-16 Thread Kristina Brooks via cfe-commits
It seems to have been causing asserts to trip on 64-bit hosts while running tests (ppc64be, ppc64le and x86_64 were all affected), ie: http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/builds/9528/steps/test-suite/logs/test.log On Fri, May 17, 2019 at 6:51 AM via cfe-commits

Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

2019-05-16 Thread Richard Smith via cfe-commits
I'm looking into this; feel free to revert, or I will if I don't find what's up shortly. Sorry for the problems! On Thu, 16 May 2019 at 22:51, via cfe-commits wrote: > > I'm not sure that is problem. Our internal linux build bot also hit the same > problem and it has a 64-bit CPU. > > Douglas

RE: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

2019-05-16 Thread via cfe-commits
I'm not sure that is problem. Our internal linux build bot also hit the same problem and it has a 64-bit CPU. Douglas Yung -Original Message- From: cfe-commits On Behalf Of Chris Bieneman via cfe-commits Sent: Thursday, May 16, 2019 22:45 To: Chris Bieneman Cc: Richard Smith ;

Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

2019-05-16 Thread Chris Bieneman via cfe-commits
I did some digging before reverting. The bots your patch is failing on are 32-bit CPUs. It looks like your static_assert is assuming 8-byte aligned pointers, so it always fails on the 32-bit builders. -Chris > On May 16, 2019, at 10:14 PM, Chris Bieneman wrote: > > Sorry to do this, but I'm

Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

2019-05-16 Thread Chris Bieneman via cfe-commits
Sorry to do this, but I'm also reverting r360977, because it seems to be on top of this one. -Chris > On May 16, 2019, at 9:58 PM, Chris Bieneman via cfe-commits > wrote: > > Hey Richard, > > This change is tripping up a bunch of the bots: > >

Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

2019-05-16 Thread Chris Bieneman via cfe-commits
Hey Richard, This change is tripping up a bunch of the bots: http://lab.llvm.org:8011/builders/clang-cmake-armv8-lld/builds/1397 I'm going to revert it so that we don't leave the bots broken overnight. -Chris > On May 16, 2019, at 6:46 PM, Richard Smith via cfe-commits > wrote: > > Author: