Re: r361278 - [clang][Darwin] Refactor header search path logic into the driver

2019-05-21 Thread Galina Kistanova via cfe-commits
Hello Louis, This commit broke few tests on the next builder: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/17776 Please have a look ASAP? . . . Failing Tests (4): Clang :: Driver/darwin-header-search-libcxx.cpp Clang ::

RE: r361278 - [clang][Darwin] Refactor header search path logic into the driver

2019-05-21 Thread via cfe-commits
Hi Louis, The three tests you added all seem to be failing when run on Windows. I suspect the reason is because you define TOOLCHAIN as an argument to FileCheck, which causes the line separators to be escaped, which then causes the FileCheck to fail. For example, see this test output

Re: r361278 - [clang][Darwin] Refactor header search path logic into the driver

2019-05-21 Thread Richard Smith via cfe-commits
Awesome! But... this resulted in two test failures for me. I've fixed them in r361301, can you check that's correct? On Tue, 21 May 2019 at 10:45, Louis Dionne via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ldionne > Date: Tue May 21 10:48:04 2019 > New Revision: 361278 > > URL: