Re: [Diffusion] rL248438: Fix loop-convert for trivially copyable types.

2015-09-24 Thread Alexander Kornienko via cfe-commits
alexfh added a subscriber: cfe-commits. alexfh added a comment. Test test test. Let's see how adding subscribers from the comments form in Diffusion works. /clang-tools-extra/trunk/test/clang-tidy/modernize-loop-convert-basic.cpp:621 Testtesttest Users: klimek (Author)

Re: [Diffusion] rL248438: Fix loop-convert for trivially copyable types.

2015-09-24 Thread Alexander Kornienko via cfe-commits
On Thu, Sep 24, 2015 at 10:24 AM, Alexander Kornienko wrote: > alexfh added a subscriber: cfe-commits. > alexfh added a comment. > > Test test test. > > Let's see how adding subscribers from the comments form in Diffusion works. > > >

Re: [Diffusion] rL248438: Fix loop-convert for trivially copyable types.

2015-09-24 Thread Manuel Klimek via cfe-commits
The biggest problem is that those comments don't go on the cfe-commmits thread that gets auto-triggered by commits, and we really want to not add new threads. On Thu, Sep 24, 2015 at 4:28 AM Alexander Kornienko wrote: > alexfh added inline comments. > >

Re: [Diffusion] rL248438: Fix loop-convert for trivially copyable types.

2015-09-24 Thread Alexander Kornienko via cfe-commits
Too bad. Making these two kinds of mails go to the same thread is hardly a trivial thing. And completely switching commit notifications to Phabricator is something not very realistic, I guess (at least, at this point). Giving up. On Thu, Sep 24, 2015 at 3:24 PM, Manuel Klimek

Re: [Diffusion] rL248438: Fix loop-convert for trivially copyable types.

2015-09-24 Thread Manuel Klimek via cfe-commits
Yep, as I said, I would love to do that, but it would require significant effort :( On Thu, Sep 24, 2015 at 7:03 AM Alexander Kornienko wrote: > Too bad. Making these two kinds of mails go to the same thread is hardly a > trivial thing. And completely switching commit