Re: [PATCH][Solaris] Default to -fno-cxa-finalize

From the driver point of view, how does it know if it is targeting illumos or solaris? Do they use different triples? In any case, if there is interest in the future this patch can be extended to work on illumos by * Creating a shouldUseCxaAtexitByDefault and passing in whatever information is

Re: [PATCH][Solaris] Default to -fno-cxa-finalize

On Fri, Aug 28, 2015 at 07:52:17PM +0200, Xan López via cfe-commits wrote: > There is no __cxa_finalize symbol available on recent Solaris OS > versions, so we need this flag to make non trivial C++ programs run. What do you consider as recent Solaris? When I asked, I've been told that Illumos

Re: [PATCH][Solaris] Default to -fno-cxa-finalize

On Tue, Sep 08, 2015 at 01:09:02PM +0200, Joerg Sonnenberger via cfe-commits wrote: > On Fri, Aug 28, 2015 at 07:52:17PM +0200, Xan López via cfe-commits wrote: > > There is no __cxa_finalize symbol available on recent Solaris OS > > versions, so we need this flag to make non trivial C++ programs

Re: [PATCH][Solaris] Default to -fno-cxa-finalize

On Tue, Sep 08, 2015 at 01:27:42PM +0200, Xan López via cfe-commits wrote: > > What do you consider as recent Solaris? When I asked, I've been told > > that Illumos has been providing __cxa_atexit since 2013. As such, > > disabling it for the Solaris family by default seems just wrong. > >

Re: [PATCH][Solaris] Default to -fno-cxa-finalize

On Tue, Sep 08, 2015 at 01:32:21PM +0200, Xan López via cfe-commits wrote: > On Tue, Sep 08, 2015 at 01:27:42PM +0200, Xan López via cfe-commits wrote: > > > What do you consider as recent Solaris? When I asked, I've been told > > > that Illumos has been providing __cxa_atexit since 2013. As such,

Re: [PATCH][Solaris] Default to -fno-cxa-finalize

On Mon, Sep 7, 2015 at 2:28 AM, Xan López wrote: > On Sat, Sep 05, 2015 at 12:25:28PM -0700, Saleem Abdulrasool wrote: > > > Ping? > > > > > > > Does this break with older Solaris releases? How far back did this > change > > in Solaris? The change itself should really be

Re: [PATCH][Solaris] Default to -fno-cxa-finalize

On Mon, Sep 7, 2015 at 10:34 AM, Xan López wrote: > OK! So here's the patch with a test. The patch LGTM with a minor request for tweaking the commit message to have the context about the fact that cxa_finalize.o never shipped, and so this doesn't really cause any problems for

Re: [PATCH][Solaris] Default to -fno-cxa-finalize

On Mon, Sep 07, 2015 at 10:38:08AM -0700, Saleem Abdulrasool wrote: > The patch LGTM with a minor request for tweaking the commit message to have > the context about the fact that cxa_finalize.o never shipped, and so this > doesn't really cause any problems for older releases. Right. Tried to

Re: [PATCH][Solaris] Default to -fno-cxa-finalize

OK! So here's the patch with a test. Xan On Mon, Sep 07, 2015 at 09:14:05AM -0700, Saleem Abdulrasool wrote: > On Mon, Sep 7, 2015 at 2:28 AM, Xan López wrote: > > > On Sat, Sep 05, 2015 at 12:25:28PM -0700, Saleem Abdulrasool wrote: > > > > Ping? > > > > > > > > > > Does this

Re: [PATCH][Solaris] Default to -fno-cxa-finalize

On Mon, Sep 7, 2015 at 10:42 AM, Xan López wrote: > On Mon, Sep 07, 2015 at 10:38:08AM -0700, Saleem Abdulrasool wrote: > > The patch LGTM with a minor request for tweaking the commit message to > have > > the context about the fact that cxa_finalize.o never shipped, and so this

Re: [PATCH][Solaris] Default to -fno-cxa-finalize

On Fri, Sep 4, 2015 at 1:11 AM, Xan López via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Aug 28, 2015 at 07:52:17PM +0200, Xan López via cfe-commits wrote: > > There is no __cxa_finalize symbol available on recent Solaris OS > > versions, so we need this flag to make non trivial