zaks.anna added a comment.
Looks like this patch is causing regressions:
https://llvm.org/bugs/show_bug.cgi?id=24914
Repository:
rL LLVM
http://reviews.llvm.org/D12652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
xazax.hun added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:515-517
@@ -511,1 +514,5 @@
+ /// Returns true if lambdas should be inlined. Otherwise a sink node will be
+ /// generated each time a LambdaExpr is visited.
+ bool
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247426: [Static Analyzer] Lambda support. (authored by
xazax).
Changed prior to commit:
http://reviews.llvm.org/D12652?vs=34498=34555#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12652
Files:
xazax.hun updated this revision to Diff 34498.
xazax.hun added a comment.
- Updated to latest trunk
- Added test for the defensive inline check heuristic case
- Added test for diagnostic within a lambda body
- Added test for path notes
http://reviews.llvm.org/D12652
Files:
jordan_rose added a comment.
A few comments coming late…
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:515-517
@@ -511,1 +514,5 @@
+ /// Returns true if lambdas should be inlined. Otherwise a sink node will be
+ /// generated each time a LambdaExpr is
zaks.anna added a comment.
Have you tested this on a large codebase that uses lambdas? When do you think
we should turn this on by default?
Please, add test cases that demonstrate what happens when an issue is reported
within a lambda and to check if inlined defensive checks work.
(As a
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Please, do turn on by default.
LGTM
http://reviews.llvm.org/D12652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
xazax.hun updated this revision to Diff 34285.
xazax.hun added a comment.
- Updated to newest trunk.
- Moved the feature behind an option.
- Fixed a crash when an operator() of a lambda is analyzed as a top level
function, and a ThisExpr is referring to the this in the enclosing scope (this
can
