jroelofs accepted this revision.
jroelofs added a reviewer: jroelofs.
jroelofs added a comment.
This revision is now accepted and ready to land.
Now that you've got http://reviews.llvm.org/D13155 squared away, LGTM.
http://reviews.llvm.org/D12996
jroelofs added a comment.
Oh, yeah, true.
http://reviews.llvm.org/D12996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
Won't it break hf-only builds, if you don't do both commits at the same time?
http://reviews.llvm.org/D12996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
compnerd added a comment.
It would fail to link previously anyways, since as Renato correctly explained,
you would have objects that were built with the soft float attribute, and then
were linking against hard float built object.
http://reviews.llvm.org/D12996
rengolin added a comment.
IIUC, HF builds still produce soft float attributes, and that's the problem.
http://reviews.llvm.org/D12996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd added a comment.
Yeah, I realize that we will need that part of the change as well. However, I
think that this is a sufficiently standalone piece that we can merge this first.
http://reviews.llvm.org/D12996
___
cfe-commits mailing list
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
You'll also need a corresponding patch for compiler-rt to make it use the new
name appropriately.
http://reviews.llvm.org/D12996
___
cfe-commits mailing list
