Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Sorry, this fell out of my radar. I'm ok with the changes. Ping me when you commit so I can monitor the bot for a while. http://reviews.llvm.org/D14293

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rmaprath added a comment. Would it be OK if I commit the x86 buildbot changes (Dmitri approved these earlier) while the ARM buildbot changes are being reviewed? I suppose the changes would only take effect once @gkistanova restarts/reconfigs the build-master ? Cheers, - Asiri

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

jroelofs added a comment. In http://reviews.llvm.org/D14293#287174, @rmaprath wrote: > Would it be OK if I commit the x86 buildbot changes (Dmitri approved these > earlier) while the ARM buildbot changes are being reviewed? I suppose the > changes would only take effect once @gkistanova

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

jroelofs added inline comments. Comment at: buildbot/osuosl/master/config/builders.py:880 @@ +879,3 @@ +# See: libcxxabi/test/lit.cfg +lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -lunwind -ldl -L/opt/llvm/lib/clang/3.6.0/lib/linux

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rmaprath added inline comments. Comment at: buildbot/osuosl/master/config/builders.py:880 @@ +879,3 @@ +# See: libcxxabi/test/lit.cfg +lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -lunwind -ldl -L/opt/llvm/lib/clang/3.6.0/lib/linux

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rmaprath updated this revision to Diff 39806. rmaprath added a comment. Updated patch to remove the skipping of tests. Now that we have the appropriate XFAILs in place, these two builders should be green. I've locally tested the x86 run, I expect the ARM run to be fairly similar. @Renato:

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rmaprath added a comment. In http://reviews.llvm.org/D14293#280982, @rengolin wrote: > Hi Asiri, > > Can I propose a different approach? > > We now have a silent buildbot, which will never email people about breakages, > but can be publicly monitored by you, me and others. I'm assuming you have

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rengolin added a comment. Hi Asiri, Can I propose a different approach? We now have a silent buildbot, which will never email people about breakages, but can be publicly monitored by you, me and others. I'm assuming you have access to at least one x86 and one ARM machines, so that you could

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

jroelofs added a comment. > Counter proposal, we mark all the currently failing (-fno-exceptions) test > cases with: > > // XFAIL: libcpp-no-exceptions > > > This has the following advantages: > > - No need to change buildbots to skip tests > - The bots will catch any regressions

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rengolin added a comment. In http://reviews.llvm.org/D14293#281176, @jroelofs wrote: > I think this ^ is a reasonable solution. I'm fine with that, as long as everyone's happy. 160 XFAILs are ok (as long as you're fixing them), disabling the tests makes no sense. :) cheers, --renato

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rmaprath added a comment. In http://reviews.llvm.org/D14293#281183, @rengolin wrote: > In http://reviews.llvm.org/D14293#281176, @jroelofs wrote: > > > I think this ^ is a reasonable solution. > > > I'm fine with that, as long as everyone's happy. > > 160 XFAILs are ok (as long as you're fixing

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rmaprath added a comment. PS: I've run a couple of hand-crafted builders on a locally hacked up buildbot and made sure the above changes are fine. http://reviews.llvm.org/D14293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

gribozavr added a comment. The Debian configuration LGTM. http://reviews.llvm.org/D14293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

jroelofs added a subscriber: jroelofs. Comment at: buildbot/osuosl/master/config/builders.py:771 @@ +770,3 @@ + # the -fno-exceptions library build. + additional_features={'no-libcxx-tests'}), + 'category': 'libcxx'}, How bad is

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rmaprath added inline comments. Comment at: buildbot/osuosl/master/config/builders.py:771 @@ +770,3 @@ + # the -fno-exceptions library build. + additional_features={'no-libcxx-tests'}), + 'category': 'libcxx'}, jroelofs wrote: >

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rmaprath added inline comments. Comment at: buildbot/osuosl/master/config/builders.py:874 @@ -842,1 +873,3 @@ 'CMAKE_CXX_FLAGS': '-mcpu=cortex-a15'})}, + +# Cortex-A15 -fno-exceptions libcxx build (skips libcxx tests)