rjmccall added a comment.
LGTM.
http://reviews.llvm.org/D14864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidKreitzer added a comment.
Looks good, Alexey! I have no further comments.
- Dave
http://reviews.llvm.org/D14864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
Ok, extracted all MCU specific changes to separate target class.
http://reviews.llvm.org/D14864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev updated this revision to Diff 40904.
http://reviews.llvm.org/D14864
Files:
lib/Basic/Targets.cpp
test/Sema/callingconv-iamcu.c
Index: lib/Basic/Targets.cpp
===
--- lib/Basic/Targets.cpp
+++ lib/Basic/Targets.cpp
@@
ABataev updated this revision to Diff 41004.
ABataev added a comment.
Renamed MCU target class
http://reviews.llvm.org/D14864
Files:
lib/Basic/Targets.cpp
test/Sema/callingconv-iamcu.c
Index: lib/Basic/Targets.cpp
===
---
DavidKreitzer added a comment.
Thanks, Alexey! I think this is an improvement.
I don't know if anyone else has an opinion on the name of the new class, but I
would prefer X86 over I386, possibly even MCUX86_32TargetInfo.
Thanks,
- Dave
http://reviews.llvm.org/D14864
