Re: [PATCH] D15623: Add UnnecessaryCopyInitialization check to new "performance" module in ClangTidy

2015-12-30 Thread Alexander Kornienko via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256632: [clang-tidy] Add UnnecessaryCopyInitialization check to new "performance"… (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D15623?vs=43743&id=43776#toc Repository: rL L

Re: [PATCH] D15623: Add UnnecessaryCopyInitialization check to new "performance" module in ClangTidy

2015-12-30 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! I'll commit the patch for you. http://reviews.llvm.org/D15623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

Re: [PATCH] D15623: Add UnnecessaryCopyInitialization check to new "performance" module in ClangTidy

2015-12-29 Thread Felix Berger via cfe-commits
flx updated this revision to Diff 43743. flx marked 2 inline comments as done. http://reviews.llvm.org/D15623 Files: clang-tidy/CMakeLists.txt clang-tidy/Makefile clang-tidy/performance/CMakeLists.txt clang-tidy/performance/PerformanceTidyModule.cpp clang-tidy/performance/UnnecessaryCop

Re: [PATCH] D15623: Add UnnecessaryCopyInitialization check to new "performance" module in ClangTidy

2015-12-29 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Thank you for working on this! A few minor comments. Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:21 @@ +20,3 @@ +namespace { +AST_MATCHER(VarDecl, isLocalVarDecl) { return Node.isLocalVarDecl(); } +AST_MATCHER(QualType, isPointer