dsanders updated this revision to Diff 45531.
dsanders added a comment.
Added one more. It was also guarded by a check for ru_RU.UTF-8 so it was missed
on the first sweep.
http://reviews.llvm.org/D16406
Files:
test/std/input.output/file.streams/fstreams/filebuf.virtuals/overflow.pass.cpp
dsanders added a comment.
Thanks. I've added one more which came up after enabling all the missing
locales except for en_US.UTF-8.
I'll commit this and find the other 8 with grep afterwards.
http://reviews.llvm.org/D16406
___
cfe-commits mailing
bcraig added a subscriber: bcraig.
bcraig added a comment.
LGTM, but that doesn't mean much.
I suspect that there are some tests that have snuck past this sweep, but I
haven't done the work to figure out which ones. I base this statement off of
these search results...
LOCALE_en_US_UTF_8 found
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258403: [libcxx] Add appropriate 'REQUIRE' directives to
tests that require en_US.UTF-8. (authored by dsanders).
Changed prior to commit:
http://reviews.llvm.org/D16406?vs=45531=45533#toc
Repository:
dsanders added a comment.
Hi,
I'd like to merge this to the 3.8 branch once it has been accepted.
http://reviews.llvm.org/D16406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits