Re: [PATCH] D17772: [clang-tidy]: string_view of temporary string

jbcoe abandoned this revision. jbcoe added a comment. rendered obsolete by http://reviews.llvm.org/D17811 Repository: rL LLVM http://reviews.llvm.org/D17772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17772: [clang-tidy]: string_view of temporary string

Maybe config options could allow addition of owning and non-owning pairs? I'd like to do that as an extension if this path is approved. Jon On 1 March 2016 at 12:29, David Blaikie wrote: > Any way to/would it be worth broadening this with an annotation or some > such (or

Re: [PATCH] D17772: [clang-tidy]: string_view of temporary string

alexfh added a comment. As David noted, there are other similar classes like `llvm::StringRef`, `llvm::ArraryRef`, `gsl::span`, `StringPiece` (in various Google projects, e.g. https://github.com/google/re2/blob/master/re2/stringpiece.h) and numerous other in different code bases. I think, we

Re: [PATCH] D17772: [clang-tidy]: string_view of temporary string

Any way to/would it be worth broadening this with an annotation or some such (or just a lost for now) of types that maintain references to their ctor params? (Eg: llvm arrayref, etc) On Mar 1, 2016 9:19 AM, "Jonathan B Coe via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > jbcoe created this

Re: [PATCH] D17772: [clang-tidy]: string_view of temporary string

dblaikie added a subscriber: dblaikie. dblaikie added a comment. Any way to/would it be worth broadening this with an annotation or some such (or just a lost for now) of types that maintain references to their ctor params? (Eg: llvm arrayref, etc) Repository: rL LLVM