Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

mspertus closed this revision. mspertus added a comment. Committed as revision 262933 http://reviews.llvm.org/D17908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM. thank you! http://reviews.llvm.org/D17908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

mspertus updated this revision to Diff 50022. mspertus added a comment. Based on Eric Feiveson's comment that I can suppress the numeric value of an enum visualization with ", en" I have uploaded a new diff. By suppressing the numeric values, instead of the verbose TemplateArgumentLoc

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

mspertus updated this revision to Diff 50015. mspertus added a comment. Updated in response to review comments to fix issues around MSVC versions http://reviews.llvm.org/D17908 Files: clang.natvis Index: clang.natvis === ---

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

aaron.ballman added a comment. In http://reviews.llvm.org/D17908#369337, @mspertus wrote: > Hmm, testing reveals that the preexisting clang.natvis does not work in > VS2013! > > Natvis: E:\Users\mspertus\Documents\Visual Studio > 2013\Visualizers\clang.natvis(59,21): Error: identifier >

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

mspertus added a comment. Hmm, testing reveals that the preexisting clang.natvis does not work in VS2013! Natvis: E:\Users\mspertus\Documents\Visual Studio 2013\Visualizers\clang.natvis(59,21): Error: identifier "clang::TypeAlignmentInBits" is undefined If I change all clang.natvis

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

mspertus added a comment. I believe that it will all work on VS2013 (and have kicked off a build to confirm). I guess I would rather drop the number so it doesn't get out of sync whenever the base compiler version changes. http://reviews.llvm.org/D17908

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

aaron.ballman added a comment. In http://reviews.llvm.org/D17908#368972, @zturner wrote: > Natvis has hardly changed at all since it was introduced, so I'm guessing > the lowest common denominator is always going to be our minimum required VS > version Awesome! Sold on removing the date.

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

zturner added a comment. Natvis has hardly changed at all since it was introduced, so I'm guessing the lowest common denominator is always going to be our minimum required VS version http://reviews.llvm.org/D17908 ___ cfe-commits mailing list

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

Natvis has hardly changed at all since it was introduced, so I'm guessing the lowest common denominator is always going to be our minimum required VS version On Mon, Mar 7, 2016 at 7:09 AM Aaron Ballman wrote: > aaron.ballman added a comment. > > In

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

aaron.ballman added a comment. In http://reviews.llvm.org/D17908#368969, @zturner wrote: > Better yet, just delete the number The number is sort of helpful since it's the only documentation as to what least common denominator we support. I don't have a strong attachment to the number,

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

zturner added a subscriber: zturner. zturner added a comment. Better yet, just delete the number http://reviews.llvm.org/D17908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

Better yet, just delete the number On Mon, Mar 7, 2016 at 6:21 AM Aaron Ballman wrote: > aaron.ballman added inline comments. > > > Comment at: clang.natvis:1-3 > @@ -1,4 +1,4 @@ > > Do you know if these visualizers will work in MSVC 2013 as well, or

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

aaron.ballman added inline comments. Comment at: clang.natvis:1-3 @@ -1,4 +1,4 @@