pirama added inline comments.
Comment at: cfe/trunk/lib/CodeGen/TargetInfo.cpp:5109
@@ -5108,3 +5108,3 @@
// natively, and does not need to interwork with AAPCS code.
- if (Ty->isHalfType() && !getContext().getLangOpts().OpenCL) {
+ if (Ty->isHalfType() &&
Anastasia added a subscriber: Anastasia.
Anastasia added a comment.
Has this commit been merged without being approved by all the reviewers?
Comment at: cfe/trunk/lib/CodeGen/TargetInfo.cpp:5109
@@ -5108,3 +5108,3 @@
// natively, and does not need to interwork with AAPCS
olista01 accepted this revision.
olista01 added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D18138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pirama added a comment.
Thanks for the review!
Repository:
rL LLVM
http://reviews.llvm.org/D18138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263795: Add -fnative-half-arguments-and-returns (authored by
pirama).
Changed prior to commit:
http://reviews.llvm.org/D18138?vs=50564=51036#toc
Repository:
rL LLVM
http://reviews.llvm.org/D18138
srhines added a reviewer: kristof.beyls.
srhines added a comment.
Kristof, can you or someone at ARM (where this is clearly relevant) take a look
here? The CL obviously looks fine to me, but I might not have all of the
original context as to why this was so constrained to OpenCL. Thanks.
