Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

Dear Richard Smith and Faisal Vali, this patch broke my code. I've filled a bug report here: https://llvm.org/bugs/show_bug.cgi?id=27507 I tried to reduce the testcase with delta but over the weekend it only managed to reduce it from 500k LOC to 300k LOC, sorry for that. If there is anything I

Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

faisalv closed this revision. faisalv marked 3 inline comments as done. faisalv added a comment. Committed as r263921 http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160321/153258.html http://reviews.llvm.org/D18139 ___ cfe-commits

Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

rsmith added a comment. Couple more things: 1. Please add some testing to tests/CXX/expr/expr.prim/expr.prim.lambda 2. Please update cxx_status.html http://reviews.llvm.org/D18139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: include/clang/AST/LambdaCapture.h:48 @@ +47,3 @@ + // by value or reference. + // - or, points to the VLASentinel if this represents a by VLA

Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

faisalv updated this revision to Diff 50757. faisalv added a comment. Added some more comments (hopefully didn't go overboard). Thanks again for reviewing Richard! http://reviews.llvm.org/D18139 Files: include/clang/AST/LambdaCapture.h include/clang/Basic/DiagnosticParseKinds.td

Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

faisalv updated this revision to Diff 50698. faisalv marked 3 inline comments as done. faisalv added a comment. Updated patch that should incorporate Richard's feedback. Thanks! http://reviews.llvm.org/D18139 Files: include/clang/AST/LambdaCapture.h

Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

faisalv marked 14 inline comments as done. faisalv added a comment. Thanks for the review! An updated patch that should address your concerns will follow in a few mins. I'm still not entirely sure I follow your comment about the intialized-entity: 'directly pass the fact that the capture in

Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

faisalv updated this revision to Diff 50621. faisalv added a comment. Add warnings and extension diagnostics for C++1z, and refactor the codegen portion, simplifying it further. Thanks! http://reviews.llvm.org/D18139 Files: include/clang/AST/LambdaCapture.h