This revision was automatically updated to reflect the committed changes.
Closed by commit rL271989: [include-fixer] Mention more details in the
document. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20467?vs=59838=59839#toc
Repository:
rL LLVM
hokein updated this revision to Diff 59838.
hokein added a comment.
Fix typo.
http://reviews.llvm.org/D20467
Files:
docs/ReleaseNotes.rst
docs/include-fixer.rst
Index: docs/include-fixer.rst
===
--- docs/include-fixer.rst
+++
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Two more nits, looks good otherwise :)
Comment at: docs/include-fixer.rst:73
@@ +72,3 @@
+
+You can custonmize the number of headers being showed by setting
+``let
hokein updated this revision to Diff 59725.
hokein marked 3 inline comments as done.
hokein added a comment.
Add comments.
http://reviews.llvm.org/D20467
Files:
docs/ReleaseNotes.rst
docs/include-fixer.rst
Index: docs/include-fixer.rst
bkramer added inline comments.
Comment at: docs/ReleaseNotes.rst:47
@@ -46,2 +46,3 @@
-- Feature1...
+- :program:`clang-include-fixer`, a tool provides an automated way of adding
+ ``#include`` directives for missing symbols in one translation unit.
a tool
hokein added a comment.
In http://reviews.llvm.org/D20467#435685, @Eugene.Zelenko wrote:
> Could you please mention include-fixer in docs/ReleaseNotes.rst? This is
> definitely major new feature in upcoming release.
Done.
http://reviews.llvm.org/D20467
hokein updated this revision to Diff 59721.
hokein marked an inline comment as done.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D20467
Files:
docs/ReleaseNotes.rst
docs/include-fixer.rst
Index: docs/include-fixer.rst
bkramer added a comment.
Sorry, this patch somehow got buried in my mail.
Comment at: docs/include-fixer.rst:69
@@ +68,3 @@
+Make sure the path of :program:`clang-include-fixer` is in the environment PATH
+variable.
+
Maybe also describe the
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Could you please mention include-fixer in docs/ReleaseNotes.rst? This is
definitely major new feature in upcoming release.
http://reviews.llvm.org/D20467
___
