This revision was automatically updated to reflect the committed changes.
Closed by commit rL271664: [clang-format] skip empty lines and comments in the
top of the code when… (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D20898?vs=59511=59538#toc
Repository:
rL LLVM
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D20898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ioeric updated this revision to Diff 59511.
ioeric added a comment.
- Nits fixed.
http://reviews.llvm.org/D20898
Files:
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTest.cpp
===
---
ioeric updated this revision to Diff 59510.
ioeric marked an inline comment as done.
ioeric added a comment.
- Switch back to range-base looping for Lines.
http://reviews.llvm.org/D20898
Files:
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTest.cpp
ioeric updated this revision to Diff 59508.
ioeric added a comment.
- Use regular Lexer instead of FormatTokenLexer.
http://reviews.llvm.org/D20898
Files:
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTest.cpp
djasper added inline comments.
Comment at: lib/Format/Format.cpp:1484
@@ +1483,3 @@
+ Environment::CreateVirtualEnvironment(Code, FileName, /*Ranges=*/{});
+ FormatTokenLexer Lexer(Env->getSourceManager(), Env->getFileID(), Style,
+
ioeric updated this revision to Diff 59497.
ioeric added a comment.
- Use FormatTokenLexer to skip comments.
http://reviews.llvm.org/D20898
Files:
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTest.cpp
djasper added a comment.
Could we very easily use the FormatTokenLexer for this? I.e. find the first
non-comment token an start from there?
http://reviews.llvm.org/D20898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ioeric added a subscriber: ioeric.
ioeric added a comment.
ping
http://reviews.llvm.org/D20898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
