This revision was automatically updated to reflect the committed changes.
Closed by commit rL273665: This patch fixes problem with passing structures and
unions (authored by spetrovic).
Changed prior to commit:
http://reviews.llvm.org/D21611?vs=61557=61777#toc
Repository:
rL LLVM
john.brawn accepted this revision.
john.brawn added a comment.
Looks OK from the ARM side as well.
http://reviews.llvm.org/D21611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.
In that case the MIPS side of this LGTM. Someone more familiar with ARM should
approve it for ARM.
http://reviews.llvm.org/D21611
___
spetrovic added a comment.
Yes, I tried all caller - callee combinations for ARM32 big endian and
MIPS/MIPS64 big endian, and it works properly with this patch.
http://reviews.llvm.org/D21611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dsanders added a comment.
This change agrees with what I think the calling convention is and the
documentation. However, I've hit quite a few discrepancies between the
documented calling convention and the de-facto one implemented by gcc so I'm
wary of going by that alone.
Have you tried
rjmccall added a comment.
Oh, floats are promoted to doubles in varargs, of course, which neatly makes
that an impossible situation.
My inclination is that the right condition here is that only integer types
should be right-justified in their slot, but I'll admit to not having an easy
example
rjmccall added a comment.
Hmm. On MIPS64, a slot is 64 bits, right? How is a float passed?
http://reviews.llvm.org/D21611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
