Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

Anastasia added a comment. In https://reviews.llvm.org/D21698#546733, @yaxunl wrote: > In https://reviews.llvm.org/D21698#540237, @Anastasia wrote: > > > I have made an experiment with a simple kernel: > > > > void foo1(void); > > void foo2(void); > > void foo3(void); > > void

Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

yaxunl added a comment. In https://reviews.llvm.org/D21698#540237, @Anastasia wrote: > I have made an experiment with a simple kernel: > > void foo1(void); > void foo2(void); > void foo3(void); > void foo4(void); > void foo5(void); > void foo6(void); > void foo7(void); > void

Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

Anastasia added a comment. I have made an experiment with a simple kernel: void foo1(void); void foo2(void); void foo3(void); void foo4(void); void foo5(void); void foo6(void); void foo7(void); void foo8(void); void foo9(void); void foo10(void); void test(){ foo1();

Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

yaxunl updated this revision to Diff 70738. yaxunl marked 5 inline comments as done. yaxunl added a comment. Revised by Anastasia's comments. https://reviews.llvm.org/D21698 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

yaxunl marked 8 inline comments as done. yaxunl added a comment. F2413912: ___10_Fiji.i F2413913: callgrind.out.20440 Uploaded the kernel used for profiling and the calgrind data. This kernel is dumped from the open source

Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

Anastasia added a comment. In https://reviews.llvm.org/D21698#537156, @yaxunl wrote: > I did profiling with valgrind for the cost of checking disabled types and > declarations. For a typical program, time spent in checking disabled types > and declarations are less than 0.1%, so this cost can

Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

yaxunl added a comment. I did profiling with valgrind for the cost of checking disabled types and declarations. For a typical program, time spent in checking disabled types and declarations are less than 0.1%, so this cost can be ignored. https://reviews.llvm.org/D21698

Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

Anastasia requested changes to this revision. Anastasia added a comment. This revision now requires changes to proceed. Have you done any investigation regarding the compilation speed as this change adds expensive container lookups for all OpenCL declarations and function calls. It would be