Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-07-13 Thread Carlo Bertolli via cfe-commits
carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 275271. Repository: rL LLVM http://reviews.llvm.org/D21904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-07-13 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D21904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-07-12 Thread Carlo Bertolli via cfe-commits
carlo.bertolli updated this revision to Diff 63689. carlo.bertolli added a comment. [OpenMP] Add regression test to check correctness of ast building, remove 'brief's, and rebase. Repository: rL LLVM http://reviews.llvm.org/D21904 Files: include/clang/AST/OpenMPClause.h

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-07-12 Thread Carlo Bertolli via cfe-commits
carlo.bertolli marked 3 inline comments as done. Comment at: lib/Sema/SemaOpenMP.cpp:11648 @@ +11647,3 @@ +// item should be a pointer or reference to pointer +if (!Type.getNonReferenceType()->isPointerType()) { + Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer)

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-07-11 Thread Alexey Bataev via cfe-commits
ABataev added a comment. I don't see successful test for the clause, which prints AST and checks serialization/deserialization. Also it should include a template test to check that dependent objects are handled correctly Comment at: include/clang/AST/OpenMPClause.h:4236 @@

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-07-11 Thread Carlo Bertolli via cfe-commits
carlo.bertolli updated this revision to Diff 63527. carlo.bertolli added a comment. [OpenMP] Apply comments: remove creation of private variable and update regression tests to include references to pointers. Repository: rL LLVM http://reviews.llvm.org/D21904 Files:

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-07-11 Thread Carlo Bertolli via cfe-commits
carlo.bertolli marked an inline comment as done. carlo.bertolli added a comment. > No positive tests for the construct Do you mean in the regression test? I thought I covered all negative and positive cases, but please let me know if I missed anything. Comment at:

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-07-11 Thread Alexey Bataev via cfe-commits
ABataev added a comment. No positive tests for the construct Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8333 @@ -8332,1 +8332,3 @@ "expected at least one 'to' clause or 'from' clause specified to '#pragma omp target update'">; +def

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-07-06 Thread Carlo Bertolli via cfe-commits
carlo.bertolli updated this revision to Diff 62878. carlo.bertolli added a comment. [OpenMP] Remove 'brief' comment tags and change error report to standard 'expected' form. Repository: rL LLVM http://reviews.llvm.org/D21904 Files: include/clang/AST/OpenMPClause.h

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-07-06 Thread Carlo Bertolli via cfe-commits
carlo.bertolli marked 4 inline comments as done. carlo.bertolli added a comment. Repository: rL LLVM http://reviews.llvm.org/D21904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-07-05 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:4221 @@ +4220,3 @@ + +/// \brief This represents clause 'use_device_ptr' in the '#pragma omp ...' +/// directives. No \brief's Comment at:

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-07-05 Thread Carlo Bertolli via cfe-commits
carlo.bertolli updated this revision to Diff 62817. carlo.bertolli added a comment. [OpenMP] Remove private variable creation from this patch as requested by comments and rebase. Repository: rL LLVM http://reviews.llvm.org/D21904 Files: include/clang/AST/OpenMPClause.h

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-06-30 Thread Alexey Bataev via cfe-commits
ABataev added a comment. In http://reviews.llvm.org/D21904#472074, @carlo.bertolli wrote: > I think that Kelvin is right. This is what that sentence refers to: > int * bla = ..; > #pragma omp target data use_device_ptr(bla) > { > > .. bla .. // <-- this is the 'reference' that sentence is

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-06-30 Thread Carlo Bertolli via cfe-commits
carlo.bertolli added a comment. I think that Kelvin is right. This is what that sentence refers to: int * bla = ..; #pragma omp target data use_device_ptr(bla) { .. bla .. // <-- this is the 'reference' that sentence is about } What puzzles me about that sentence is that it seems it is

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-06-30 Thread Kelvin Li via cfe-commits
kkwli0 added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:11377 @@ +11376,3 @@ +// item should be a pointer or array +if (!Type.getNonReferenceType()->isPointerType()) { + Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer) sfantao wrote: >

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-06-30 Thread Samuel Antao via cfe-commits
sfantao added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:11377 @@ +11376,3 @@ +// item should be a pointer or array +if (!Type.getNonReferenceType()->isPointerType()) { + Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer) ABataev wrote: >

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-06-30 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:11377 @@ +11376,3 @@ +// item should be a pointer or array +if (!Type.getNonReferenceType()->isPointerType()) { + Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer) sfantao wrote: >

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-06-30 Thread Samuel Antao via cfe-commits
sfantao added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:11377 @@ +11376,3 @@ +// item should be a pointer or array +if (!Type.getNonReferenceType()->isPointerType()) { + Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer) ABataev wrote: >

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-06-30 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8318 @@ -8317,1 +8317,3 @@ +def err_omp_usedeviceptr_not_a_pointer : Error< + "item used in 'use_device_pointer' clause is not a pointer">; } // end of OpenMP category It's