thakis closed this revision.
thakis marked an inline comment as done.
thakis added a comment.
r279866, thanks!
https://reviews.llvm.org/D23938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
majnemer's suggestion sounds good though, and for inputCharset too.
https://reviews.llvm.org/D23938
___
cfe-commits mailing list
majnemer added a subscriber: majnemer.
Comment at: lib/Driver/Tools.cpp:5838-5846
@@ -5837,11 +5837,11 @@
StringRef value = inputCharset->getValue();
if (value.lower() != "utf-8")
D.Diag(diag::err_drv_invalid_value) << inputCharset->getAsString(Args)
thakis updated this revision to Diff 69416.
thakis added a comment.
!!
https://reviews.llvm.org/D23938
Files:
include/clang/Driver/CLCompatOptions.td
lib/Driver/Tools.cpp
test/Driver/cl-options.c
Index: test/Driver/cl-options.c
thakis updated this revision to Diff 69415.
thakis added a comment.
;-;
https://reviews.llvm.org/D23938
Files:
include/clang/Driver/CLCompatOptions.td
lib/Driver/Tools.cpp
test/Driver/cl-options.c
Index: test/Driver/cl-options.c
On Friday, August 26, 2016, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> thakis created this revision.
> thakis added a reviewer: hans.
> thakis added a subscriber: cfe-commits.
>
> Like https://reviews.llvm.org/D23807, but for execution-charset.
>
>
